Ticket #18736: urlencode.diff

src/port1.0/portfetch.tcl

@@ -151 +151 @@
 # return it.
 proc portfetch::assemble_url {site distfile} {
     if {[string index $site end] != "/"} {
-        return "${site}/${distfile}"
-    } else {
-        return "${site}${distfile}"
+        set site "${site}/"
     }
+    return "${site}[urlencode ${distfile}]"
 }
 
 # XXX

src/port1.0/portutil.tcl

@@ -2210 +2222 @@
     return $str
 }
 
+##
+# Percent-encode a string for safe use in a URL
+# This code is from http::mapReply in http.tcl included with Tcl
+#
+# @param string the string to be encoded
+# @return the percent-encoded string
+proc urlencode {string} {
+    global urlencodeMap
+    set excluded -._~a-zA-Z0-9
+    if {![info exists urlencodeMap]} {
+        for {set i 1} {$i <= 256} {incr i} {
+            set c [format %c $i]
+            if {![string match \[$excluded\] $c]} {
+                set urlencodeMap($c) %[format %.2x $i]
+            }
+        }
+        # These are handled specially
+        array set urlencodeMap {
+            " " +   \n %0d%0a
+        }
+    }
+    regsub -all \[^$excluded\] $string {$urlencodeMap(&)} string
+    regsub -all \n $string {\\n} string
+    regsub -all \t $string {\\t} string
+    regsub -all {[][{})\\]\)} $string {\\&} string
+    return [subst $string]
+}