Changeset 36735

Timestamp:

05/13/2008 06:43:23 (4 years ago)

Author:

jmr@…

Message:

In image mode, don't count dependencies as being satisfied when the satisfying
port is not active. Fix for #7361.

Files:

• trunk/base/src/macports1.0/macports.tcl (modified) (3 diffs)

trunk/base/src/macports1.0/macports.tcl

@@ -1135 +1135 @@
 }
 
+# Determine if a port is active (only for image mode)
+proc _mportactive {mport} {
+    set workername [ditem_key $mport workername]
+    if {[catch {set reslist [$workername eval registry_active \${portname}]} res]} {
+        return 0
+    } else {
+        return [expr [llength $reslist] > 0]
+    }
+}
+
 ### _mportispresent is private; may change without notice
 
-# Determine if some depspec is satisfied or if the given port is installed.
+# Determine if some depspec is satisfied or if the given port is installed
+# (and active, if we're in image mode).
 # We actually start with the registry (faster?)
 #
@@ -1143 +1154 @@
 # depspec   the dependency test specification (path, bin, lib, etc.)
 proc _mportispresent {mport depspec} {
-    # Check for the presense of the port in the registry
-    set workername [ditem_key $mport workername]
     ui_debug "Searching for dependency: [ditem_key $mport provides]"
-    if {[catch {set reslist [$workername eval registry_installed \${portname}]} res]} {
-        set res 0
-    } else {
-        set res [llength $reslist]
+    if {[string equal ${macports::registry.installtype} "image"]} {
+        set res [_mportactive $mport]
+    } else {
+        set res [_mportinstalled $mport]
     }
     if {$res != 0} {
@@ -1238 +1247 @@
         # understand Port Images before this can get prettier
         if { [string equal ${macports::registry.installtype} "image"] } {
-            set result [dlist_eval $dlist _mportinstalled [list _mportexec "activate"]]
+            set result [dlist_eval $dlist _mportactive [list _mportexec "activate"]]
         } else {
             set result [dlist_eval $dlist _mportinstalled [list _mportexec "install"]]