Changeset 79637

Timestamp:

06/21/11 15:41:46 (4 years ago)

Author:

cal@…

Message:

rev-upgrade: Fixed a few typos, removed code I only guessed to be correct but doesn't seem to be

File:

• branches/gsoc11-rev-upgrade/base/src/macports1.0/macports.tcl (modified) (4 diffs)

branches/gsoc11-rev-upgrade/base/src/macports1.0/macports.tcl

@@ -3564 +3564 @@
                     x86_64 {}
                     i386 {}
-                    ppc {}
-                    ppc64 {}
+                    # todo: what are the correct string reported by otool -arch all -L for the PPC archs?
                     default {
                         ui_warn "Unknown architecture $arch"
@@ -3578 +3577 @@
             if {1 == [regexp -nocase {^\t([^\s]+) \(compatibility version ([^,]+), current version ([^)]+)\)} $otool_line match file comp_version curr_version]} {
                 if {$file == [$b path]} {
-                    # This is a self-referencing entry
+                    # library files contain themselves as their first entry in the output of otool -L
                     continue;
                 }
@@ -3591 +3590 @@
                                 if {$curr_version != $lib_curr_version} {
                                     if {$comp_version != $lib_comp_version} {
-                                        ui_warn "Incompatibly library version: Expected $comp_version, but got $lib_comp_version!"
+                                        ui_warn "Incompatible library version of $file: Expected $comp_version, but $lib_comp_version is installed!"
                                     }
                                 }
@@ -3603 +3602 @@
                 continue;
             }
-            ui_warn "unparseable line in otool output: $otool_line"
+            ui_warn "Unparsable line in otool output: $otool_line"
         }
     }