Changeset 81271

Timestamp:

07/28/11 08:24:35 (4 years ago)

Author:

cal@…

Message:

rev-upgrade: Use lremove as described in lreplace(n) rather than concat()ing two lrange()d lists

File:

• branches/gsoc11-rev-upgrade/base/src/macports1.0/macports.tcl (modified) (1 diff)

branches/gsoc11-rev-upgrade/base/src/macports1.0/macports.tcl

@@ -3888 +3888 @@
                     lappend topsort_ports $port
                     # remove from unsorted list
-                    # TODO: use lremove(n)
-                    set index [lsearch $unsorted_ports $port]
-                    set unsorted_ports [concat [lrange $unsorted_ports 0 $index-1] [lrange $unsorted_ports $index+1 end]]
+                    set index [lsearch -exact $unsorted_ports $port]
+                    set unsorted_ports [lreplace $unsorted_ports $index $index]
 
                     # remove edges 
                     foreach target $revadjlist($port) {
-                        set index [lsearch $adjlist($target) $port]
-                        set adjlist($target) [concat [lrange $adjlist($target) 0 $index-1] [lrange $adjlist($target) $index+1 end]]
+                        set index [lsearch -exact $adjlist($target) $port]
+                        set adjlist($target) [lreplace $adjlist($target) $index $index]
                     }
                 }