Changeset 81272

Timestamp:

07/28/11 09:00:13 (4 years ago)

Author:

cal@…

Message:

rev-upgrade: Repeat scanning and rebuilding until all errors are fixed or a port has been marked as broken more than 3 times.

File:

• branches/gsoc11-rev-upgrade/base/src/macports1.0/macports.tcl (modified) (5 diffs)

branches/gsoc11-rev-upgrade/base/src/macports1.0/macports.tcl

@@ -3749 +3749 @@
 
 proc macports::revupgrade {args} {
+    set run_loop 1
+    array set broken_port_counts {}
+    while {$run_loop == 1} {
+        if {[catch {revupgrade_scanandrebuild broken_port_counts} run_loop] == 1} {
+            ui_error "An error occured while scanning for broken ports and/or trying to rebuild them"
+            error "An error occured while scanning for broken ports and/or trying to rebuild them"
+        }
+    }
+    return 0;
+}
+
+# returns 1 if ports were rebuilt and revupgrade_scanandrebuild should be called again
+proc revupgrade_scanandrebuild {broken_port_counts_name} {
+    upvar $broken_port_counts_name broken_port_counts
+
     set files [registry::file search active 1 binary -null]
     if {[llength $files] > 0} {
@@ -3761 +3776 @@
                 }
             } catch {*} {
-                ui_msg "Updating database of binaries failed"
+                ui_error "Updating database of binaries failed"
                 throw
             }
@@ -3786 +3801 @@
 
             if {$returncode != $machista::SUCCESS} {
-                ui_warn "Error parsing file [$b path]: [machista::strerror $returncode]"
+                ui_info "Error parsing file [$b path]: [machista::strerror $returncode]"
                 continue;
             }
@@ -3857 +3872 @@
         }
         set broken_ports [lsort -unique $broken_ports]
+
+        foreach port $broken_ports {
+            if {![info exists broken_port_counts([$port name])]} {
+                set broken_port_counts([$port name]) 0
+            }
+            incr broken_port_counts([$port name])
+            if {$broken_port_counts([$port name]) > 3} {
+                ui_error "Port [$port name] is still broken after rebuiling it more than 3 times. You might want to file a bug for this."
+                error "Port [$port name] still broken after rebuilding $broken_port_counts([$port name]) time(s)"
+            }
+        }
 
         ui_msg "---> Found [llength $broken_ports] broken port(s), determining rebuild order"
@@ -3904 +3930 @@
             ui_msg "     [$port name] @[$port version] [$port variants][$port negated_variants]"
         }
+
+        return 1;
     }