Changeset 82546

Timestamp:

08/15/11 09:00:04 (4 years ago)

Author:

ryandesign@…

Message:

app-1.0.tcl: use variable tracing magic to automatically add makeicns build dependency if needed

Location:

trunk/dports

Files:

• _resources/port1.0/group/app-1.0.tcl (modified) (1 diff)
• databases/sqliteman/Portfile (modified) (1 diff)
• games/chromium-bsu/Portfile (modified) (1 diff)
• games/gdash/Portfile (modified) (1 diff)
• graphics/gvedit-devel/Portfile (modified) (1 diff)

trunk/dports/_resources/port1.0/group/app-1.0.tcl

@@ -253 +253 @@
 }
 
-# TODO: automatically add depends_build-append port:makeicns
+
+# Trace writes to app.icon and add or remove makeicns dependency as necessary.
+trace variable app.icon w app._icon_trace
+
+proc app._icon_trace {optionName unusedIndex unusedOperation} {
+    global depends_build
+    upvar ${optionName} option
+    set has_dep [expr {[lsearch ${depends_build} port:makeicns] != -1}]
+    set needs_dep [expr {[file extension ${option}] != ".icns"}]
+    if {${has_dep} && !${needs_dep}} {
+        depends_build-delete port:makeicns
+    } elseif {${needs_dep} && !${has_dep}} {
+        depends_build-append port:makeicns
+    }
+}
+
+
 # TODO: for Tiger we probably need our own lreverse implementation e.g. http://wiki.tcl.tk/17188

trunk/dports/databases/sqliteman/Portfile

@@ -42 +42 @@
 configure.args      ${qt_cmake_defines}
 
-platform macosx {
-    depends_build-append port:makeicns
-}
-
 app.icon            sqliteman/icons/sqliteman.png

trunk/dports/games/chromium-bsu/Portfile

@@ -48 +48 @@
 app.icon                misc/chromium-bsu.png
 
-platform macosx {
-    depends_build-append port:makeicns
-}
-
 livecheck.distname      Chromium%20B.S.U.%20source%20code
 livecheck.url           http://sourceforge.net/projects/chromium-bsu/files/${livecheck.distname}

trunk/dports/games/gdash/Portfile

@@ -33 +33 @@
                     --disable-sdltest
 
-platform macosx {
-    depends_build-append port:makeicns
-}
-
 app.name            SDash
 app.executable      sdash

trunk/dports/graphics/gvedit-devel/Portfile

@@ -51 +51 @@
 app.icon                        ${build.dir}/images/icon.png
 
-platform macosx {
-    depends_build-append port:makeicns
-}
-
 pre-destroot {
     app.short_version_string [get_short_version_string]