Changeset 83267

Timestamp:

08/29/11 05:05:57 (4 years ago)

Author:

jmr@…

Message:

unset TMP/TMPDIR in env if it's not writable or doesn't look like it will be writable by macportsuser (#30749)

File:

• trunk/base/src/macports1.0/macports.tcl (modified) (5 diffs)

trunk/base/src/macports1.0/macports.tcl

@@ -839 +839 @@
     }
 
+    # make tools we run operate in UTF-8 mode
+    set env(LANG) en_US.UTF-8
+
     # ENV cleanup.
     set keepenvkeys {
@@ -845 +848 @@
         DYLD_LIBRARY_PATH DYLD_INSERT_LIBRARIES
         HOME JAVA_HOME MASTER_SITE_LOCAL ARCHIVE_SITE_LOCAL
-        PATCH_SITE_LOCAL PATH PORTSRC RSYNC_PROXY TMP TMPDIR
-        USER GROUP
+        PATCH_SITE_LOCAL PATH PORTSRC RSYNC_PROXY
+        USER GROUP LANG
         http_proxy HTTPS_PROXY FTP_PROXY ALL_PROXY NO_PROXY
         COLUMNS LINES
@@ -852 +855 @@
     if {[info exists extra_env]} {
         set keepenvkeys [concat ${keepenvkeys} ${extra_env}]
-    }
-
-    set env_names [array names env]
-    foreach envkey $env_names {
-        if {[lsearch -exact $keepenvkeys $envkey] == -1} {
-            unset env($envkey)
-        }
-    }
-
-    # make tools we run operate in UTF-8 mode
-    set env(LANG) en_US.UTF-8
-
-    if {![info exists xcodeversion] || ![info exists xcodebuildcmd]} {
-        # We'll resolve these later (if needed)
-        trace add variable macports::xcodeversion read macports::setxcodeinfo
-        trace add variable macports::xcodebuildcmd read macports::setxcodeinfo
-    }
-
-    # Set the default umask
-    if {![info exists destroot_umask]} {
-        set destroot_umask 022
-    }
-
-    if {[info exists master_site_local] && ![info exists env(MASTER_SITE_LOCAL)]} {
-        set env(MASTER_SITE_LOCAL) "$master_site_local"
-    }
-    if {[info exists patch_site_local] && ![info exists env(PATCH_SITE_LOCAL)]} {
-        set env(PATCH_SITE_LOCAL) "$patch_site_local"
-    }
-    if {[info exists archive_site_local] && ![info exists env(ARCHIVE_SITE_LOCAL)]} {
-        set env(ARCHIVE_SITE_LOCAL) "$archive_site_local"
     }
 
@@ -899 +871 @@
     }
 
+    # don't keep unusable TMPDIR/TMP values
+    foreach var {TMP TMPDIR} {
+        if {[info exists env($var)] && [file writable $env($var)] && 
+            ([getuid] != 0 || $macportsuser == "root" ||
+             [file attributes $env($var) -owner] == $macportsuser)} {
+            lappend keepenvkeys $var
+        }
+    }
+
+    set env_names [array names env]
+    foreach envkey $env_names {
+        if {[lsearch -exact $keepenvkeys $envkey] == -1} {
+            unset env($envkey)
+        }
+    }
+
     # unset environment an extra time, to work around bugs in Leopard Tcl
     if {$macosx_version == "10.5"} {
@@ -906 +894 @@
             }
         }
+    }
+
+    if {![info exists xcodeversion] || ![info exists xcodebuildcmd]} {
+        # We'll resolve these later (if needed)
+        trace add variable macports::xcodeversion read macports::setxcodeinfo
+        trace add variable macports::xcodebuildcmd read macports::setxcodeinfo
+    }
+
+    # Set the default umask
+    if {![info exists destroot_umask]} {
+        set destroot_umask 022
+    }
+
+    if {[info exists master_site_local] && ![info exists env(MASTER_SITE_LOCAL)]} {
+        set env(MASTER_SITE_LOCAL) "$master_site_local"
+    }
+    if {[info exists patch_site_local] && ![info exists env(PATCH_SITE_LOCAL)]} {
+        set env(PATCH_SITE_LOCAL) "$patch_site_local"
+    }
+    if {[info exists archive_site_local] && ![info exists env(ARCHIVE_SITE_LOCAL)]} {
+        set env(ARCHIVE_SITE_LOCAL) "$archive_site_local"
     }