Projects
New Ticket     Wiki     Browse Source     Timeline     Roadmap     Bug Reports     Search

Ticket #11914 (closed enhancement: fixed)

Opened 19 months ago

Last modified 16 months ago

RFE: rb-dbi / db-dbd-* 0.0.23 move to use variants instead of separate ports

Reported by: t.lucas@… Owned by: boeyms@…
Priority: Low Milestone: Port Enhancements
Component: ports Version:
Keywords: ruby rb-dbi databases variants Cc: roberto@…, t.lucas@…, boeyms@…, shu@…
Port:

Description

Currently to install rb-dbi with extra database modules requires installing separate ports, i.e. db-dbd-mysql and rb-dbd-postgresql. Both of these ports do pretty much the same thing: add a dependency, and install rb-dbi with an extra configure line. The biggest problem is you can't have both the mysql and postgresql DBI drivers intalled at the same time. As there's other Ruby-DBI drivers too (like #11913) things would get worse as more drivers are added.

Wouldn't variants be a better solution?

port install rb-dbi +mysql +postgresql +odbc

Attachments

rb-dbi_variants.diff (1.2 KB) - added by boeyms@… 19 months ago.

Change History

Changed 19 months ago by pipping@…

  • milestone set to Port Enhancements

Changed 19 months ago by boeyms@…

  • cc t.lucas@…, boeyms@…, shu@… added
  • owner changed from macports-dev@… to boeyms@…

Reassign ticket to boeyms (myself) and add reporter, maintainer and myself to the Cc: field.

Changed 19 months ago by boeyms@…

  • status changed from new to assigned
  • version changed from 1.5 to 1.4.3

The attached file is a suggested patch to rb-dbi that adds variants to it to address this ticket, which would make obsolete rb-dbd-mysql, rb-dbd-pg and #11913 submitted to create rb-dbd-odbc. It built successfully with +dbd_pg for me, but I was unable to test +dbd_mysql or +dbd_odbc as sources for some of their required dependencies were not available from the listed master_sites at the time of testing.

It is designed to be applied using -p0 from the dports directory.

Changed 19 months ago by boeyms@…

Changed 19 months ago by t.lucas@…

Great, thanks! What's the best way to test this?

Changed 19 months ago by boeyms@…

I think the best way would be to create and use a local ports tree. I've just put some brief instructions on the MaintainingAPort wiki page; see how you go with those.

Changed 19 months ago by t.lucas@…

Hey I finally checked this out and they all work: mysql, odbc and postgresql. Thanks Boey. As far as I can tell this is good to be committed.

Changed 19 months ago by boeyms@…

  • keywords ruby rb-dbi databases variants added
  • status changed from assigned to closed
  • resolution set to fixed

Committed in r25233 as no correspondence has been received from the maintainer. Thanks for the report!

Changed 16 months ago by nox@…

  • priority changed from Nice to have to Low
  • version 1.4.3 deleted
Note: See TracTickets for help on using tickets.