Projects
New Ticket     Wiki     Browse Source     Timeline     Roadmap     Bug Reports     Search

Ticket #12247 (new defect)

Opened 17 months ago

Last modified 16 months ago

BUG: Makefiles require GNU make

Reported by: afb@… Owned by: macports-tickets@…
Priority: Low Milestone: MacPorts base bugs
Component: base Version: 1.5
Keywords: FreeBSD support Cc:
Port:

Description

The makefiles use some commands specific to GNU make, and don't work with BSD make.

Attachments

macports-bsdmake.patch (1.7 KB) - added by afb@… 17 months ago.
macports-bsdmake.patch

Change History

Changed 17 months ago by afb@…

macports-bsdmake.patch

Changed 17 months ago by jmpp@…

  • milestone set to Needs developer review

Comments on the patch:

  • For consistency's sake, would like to see a line like [ "$(ARC)" = "yes" ] && ${MAKE} SVNTAG=${DISTARCTAG} PKGNAME=${DISTARCNAME} _dopkg in base/Makefile.in rather than the one provided using test explicitly;
  • Not sure if removing ifneq ($(MAKECMDGOALS),distclean) from base/doc/Makefile has any negative side effects, I haven't been able to spot any;
  • Not sure why we're exporting the deployment target in base/src/pextlib1.0 and in base/src/tclobjc1.0 and if removing the export keyword breaks anything, I'll let others chime in on that one.

Other than those three, the patch seems OK to me for inclusion.

-jmpp

Changed 17 months ago by jmpp@…

  • keywords FreeBSD support added

Changed 17 months ago by afb@…

"Not sure if removing ifneq ($(MAKECMDGOALS),distclean) from base/doc/Makefile has any negative side effects, I haven't been able to spot any;"

Don't think it should have any, since doc/Makefile is processed before rm -f Mk/macports.autoconf.mk

Changed 17 months ago by afb@…

  • priority changed from Expected to Nice to have

Changed 16 months ago by jmpp@…

  • milestone changed from Needs developer review to MacPorts base bugs

Milestone Needs developer review deleted

Changed 16 months ago by nox@…

  • priority changed from Nice to have to Low
  • summary changed from Makefiles require GNU make to BUG: Makefiles require GNU make
Note: See TracTickets for help on using tickets.