UPDATE: Fix openssh for leopard (percent_null errors)

[macports@…]

Openssh fails on Leopard with the errors described here:

http://blog.paulbetts.org/index.php/2007/10/27/fixing-percent_expand-null-replacement-ssh-bug-on-os-x-leopard/

To reproduce, simply:

% /opt/local/bin/ssh somehost ls

The attached patch implements the fix described on the above page, which will allow openssh to work on MacPorts until the same fix is made to the upstream sources.

This package marked 'nomaintainer', so I'm taking the liberty of assigning it to jmpp@…, the package's last committer.

[macports@…]

Patch containing Portfile update, and new files/percent_expand_fix.patch file

[callahad@…]

Original uploader's patchfile was reversed. This isn't.

[callahad@…]

Only apply the fix if the host is running leopard. (I presume that otherwise would cause a regression)

[macports@…]

Great - thanks for the corrections. I doubt that the patch would cause a regression on Tiger, but it makes sense to be cautious here.

[christian@…]

How long will it take until the patch makes its way into the repository and onto my machine?

p.s.: I'd like to follow up on this and be on CC: but unfortunately may not edit the ticket details. Anyone cares to put me on cc:?

[ryandesign@…]

According to this page, no patch is necessary. Comments from people running Leopard? Does that work for you?

[christian@…]

Yes, that does work for me.

However, I feel like adding an option that basically reflects just the default value isn't nice. It should work with the default setup: That doesn't have a ~/.ssh/config file, but might have keys set up.

[ryandesign@…]

jmpp's last change to this port in r30239 was not anything specific to this port; in fact it was part of a series of changes from r30187 to r30260 that affected thousands of ports. So there's no reason to assign this ticket to him.

[macports@…]

Apologies for the confused initial assignment to jmpp.

The page describes a workaround for a definite problem in openssh.

OpenSSH should get fixed upstream in due course, and my hope in submitting this patch was that making the tiny fix locally in MacPorts would save the time of many Leopard users, and spare them from looking for answers on the MacPorts mailing list or via the Trac.

[macports@…]

Update: I found a ticket for the issue upstream in the OpenSSH bugzilla -

https://bugzilla.mindrot.org/show_bug.cgi?id=1377

It includes an enhanced version of the patch included in this ticket.

[ram@…]

fixed in r32161