New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #10785 (closed enhancement: fixed)

Opened 7 years ago

Last modified 4 years ago

Archivemode should look for an existing archive before attempting to build it

Reported by: dluke@… Owned by: macports-tickets@…
Priority: Normal Milestone: MacPorts 1.8.0
Component: base Version:
Keywords: Cc: jmpp@…, jmr@…
Port:

Description

As I mentioned on the list, when we changed the target from 'archive' to 'unarchive' we made the time when the port isn't installed on the machine when archivemode is active much longer than it needs to be.

I think the proper behavior would be restored if we change back to 'archive' and modify archive to check for existing archives and not attempt to recreate them if they already exists.

I've got a patch that I haven't done any testing at all to yet (not even to see if the syntax is correct) that I'll attach as my first idea on how to do this.

Attachments

upgrade_fix.patch (1.1 KB) - added by dluke@… 7 years ago.
Make 'archive' target work correctly for upgrade

Change History

Changed 7 years ago by dluke@…

Make 'archive' target work correctly for upgrade

comment:1 Changed 6 years ago by pipping@…

  • Milestone set to MacPorts 1.4

comment:2 Changed 6 years ago by jmpp@…

  • Priority changed from Nice to have to Expected
  • Cc jmpp@… added
  • Milestone changed from MacPorts 1.4 to MacPorts 1.5
  • Owner changed from darwinports-bugs@… to macports-dev@…
  • Summary changed from BUG: upgrade target with archivemode leaves port uninstalled for longer than necessary to Archivemode should look for an existing archive before attempting to build it

Hey Daniel! The upgrade action has been reset to archive from unarchive, so the fix for the primary issue you report will be in MacPorts 1.4. However, I'm leaving this ticket open so we can work on improving the archive target to look for already existing archives and not rebuilding them unnecessarily. Adapting ticket summary accordingly, stting myself on the CC list and the ticket itself to the 1.5 milestone.

-jmpp

comment:3 Changed 6 years ago by yves@…

The same is true of port install, it should look to see if the port is already installed instead of building it and failing at installation.

comment:4 Changed 6 years ago by nox@…

  • Priority changed from Expected to Normal
  • Version 1.3.2 deleted

comment:5 Changed 6 years ago by jmpp@…

  • Type changed from defect to enhancement
  • Milestone changed from MacPorts 1.5 to MacPorts base enhancements

comment:6 Changed 4 years ago by jmr@…

  • Cc jmr@… added
  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from MacPorts Future to MacPorts 1.8.0

Fixed in r50416.

Note: See TracTickets for help on using tickets.