New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #12037 (closed update: fixed)

Opened 5 years ago

Last modified 3 years ago

UPDATE: xqf-1.0.5

Reported by: and.damore@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: adamore@…, markd@…
Port:

Description

Macports provides XQF 1.0.3, XQF compiles fine but doesn't run properly when called. I patched this by changing a dlsym() parameter that prevented in source xpms to be found.

I've also patched an internal function in order to launch executables with a space in their name, this allows to launch game such as "Wolfenstein ET" that has a space in the exec name. The workaround is done escaping white spaces with a backslash.

I've created a patch file with both fixes and I've tried it with xqf 1.0.5 . I tried from clear sources applying the patch and then using the same config line I found in macports 1.0.3 . I had to remove a few LDFLAGS and did it patching makefile.am and makefile.in as I didn't knew how to do it via configuration line .

Attachments

file.patch Download (3.6 KB) - added by suppa@… 5 years ago.
Portfile Download (1.4 KB) - added by adamore@… 4 years ago.
Portfile for xqf 1.0.5

Change History

Changed 5 years ago by suppa@…

Changed 5 years ago by markd@…

  • milestone set to Port Enhancements
  • summary changed from xqf 1.0.5 to UPDATE: xqf-1.0.5

Changed 5 years ago by adamore@…

Any comment about how to remove LDFLAGS via the config script ?

Changed 5 years ago by nox@…

  • priority changed from Expected to Normal
  • version 1.4.42 deleted
  • type changed from defect to enhancement
  • milestone changed from Port Enhancements to Port Updates

Changed 5 years ago by markd@…

  • cc adamore@…, markd@… added

Sorry no one responded earlier. You can remove CFLAGS by using configure.cflags-delete. So what needs to be done to complete the update?

Changed 4 years ago by raimue@…

Shouldn't this kind of patch rather be applied upstream as it fixes a general bug in the software?

Changed 4 years ago by adamore@…

What do you mean by "applying upstream" the patch?

Changed 4 years ago by raimue@…

Your patch fixes bugs in xqf. Please also send this patch to the author of xqf.

Changed 4 years ago by adamore@…

I already did it, as far as I remember, but I never got any reply. XQF seems an "old" project with 1 or 2 minor update at year, one in 2006, none in 2007.

Changed 4 years ago by adamore@…

Portfile for xqf 1.0.5

Changed 4 years ago by adamore@…

Rename "file.patch" to patch-xqf-1.0.5 before committing it.

Changed 4 years ago by raimue@…

  • status changed from new to closed
  • resolution set to fixed

Committed in r35969.

Changed 3 years ago by jmr@…

  • type changed from enhancement to update

Changed 3 years ago by anonymous

  • milestone Port Updates deleted

Milestone Port Updates deleted

Note: See TracTickets for help on using tickets.