boost 1.33.1 -> boost 1.34 portfile diff

[sanchom@…]

I'm submitting a unified diff of the changes to the boost portfile. This brings boost from 1.33.1 to 1.34.

I removed the icu variant because this is automatically detected at the configuration stage.

[sanchom@…]

boost 1.33.1 -> boost 1.34 portfile upgrade

[nox@…]

"I removed the icu variant because this is automatically detected at the configuration stage."

That's actually a very bad thing, if icu is then uninstalled, boost will be broken. icu dependency must be clearly stated in the port.

[ryandesign@…]

Committed in r26030; thank you.

[ryandesign@…]

Oh... sorry... I didn't see the comment by nox before I committed. Yes, I agree, the dependency on icu needs to be declared, as it was in the line you removed:

depends_lib             lib:libicuuc:icu

Note that we now prefer dependencies to be stated using the port: syntax (e.g. "depends_lib port:icu") instead of the lib: syntax.

[sanchom@…]

Okay, so I reinstated the icu variant. Do you want the diff from the previous 1.33.1 portfile to the current portfile with the icu variant reinstated?

[ryandesign@…]

Since I've already committed your previous diff, I'd prefer a diff against the portfile from r26030.

[sanchom@…]

boost 1.34 portfile diff now includes icu variant

[sanchom@…]

new diff added

[ryandesign@…]

Portfile.2.diff applied and +icu variant reinstated in r26109. Thanks.

[anonymous]

Milestone Port Updates deleted