BUG: pextlib tests fail on freebsd/linux

[afb@…]

checksums.tcl fails with:

[md5 file $testfile] != "91d3ef5cd86741957b0b5d8f8911166d"

fs-traverse.tcl fails with:

Found `/tmp/macports-pextlib-fs-traverse/a/c/a/a', expected `/tmp/macports-pextlib-fs-traverse/a/c/a//a'
Found `/tmp/macports-pextlib-fs-traverse/a/c/a/b', expected `/tmp/macports-pextlib-fs-traverse/a/c/a//b'
Found `/tmp/macports-pextlib-fs-traverse/a/c/a/c', expected `/tmp/macports-pextlib-fs-traverse/a/c/a//c'
Found `/tmp/macports-pextlib-fs-traverse/a/c/a/d', expected `/tmp/macports-pextlib-fs-traverse/a/c/a//d'

[afb@…]

macports-pextlib-tests.patch

[afb@…]

Neither is library failure, but broken test cases...

[jmpp@…]

Setting to "needs dev review" milestone and Cc'ing eridius, as he wrote fs-traverse and the test cases (and maybe he can also give some input on the md5 failure).

-jmpp

[eridius@…]

Ok, I've fixed checksums.tcl as that wasn't a FreeBSD issue but a locale issue. As for fs-traverse, I'm rather curious about the differences your patch implies. On Darwin if I have a slash at the end of a folder and I iterate it, I get a double-slash in the child files as fts_read takes the given path, appends the path separator, and the child (and the given path in this case ends with a slash already). Your patch implies FreeBSD actually checks to make sure the given path doesn't have a slash before appending one.

Can you try the following for me and paste the results:

cd /tmp
mkdir a
ln -s a b
touch a/{a,b,c}
find a
find b
find a/
find b/

Thanks.

[afb@…]

FreeBSD and the rest of the modern world, the ​diff I found showed it fixed in 1997...

@@ -249,12 +253,12 @@ fts_close(sp)
 }
 
 /*
- * Special case a root of "/" so that slashes aren't appended which would
- * cause paths to be written as "//foo".
+ * Special case of "/" at the end of the path so that slashes aren't
+ * appended which would cause paths to be written as "....//foo".
  */
 #define	NAPPEND(p)							\
-	(p->fts_level == FTS_ROOTLEVEL && p->fts_pathlen == 1 &&	\
-	    p->fts_path[0] == '/' ? 0 : p->fts_pathlen)
+	(p->fts_path[p->fts_pathlen - 1] == '/'				\
+	    ? p->fts_pathlen - 1 : p->fts_pathlen)
 
 FTSENT *
 fts_read(sp)

Changed your test script to use "touch a/a a/b a/c" so it worked, and it said:

a/
a/a
a/b
a/c
b/
b/a
b/b
b/c

So yes, you implied correctly that the double-slash is Darwin-only...

[jmpp@…]

Milestone Needs developer review deleted

[eridius@…]

Fixed in r29414

[toby@…]

Milestone MacPorts base bugs deleted