port outdated fails with non-numeric revisions

[ehainry@…]

I have MPlayer @1.0rc1_try3 installed but port outdated reports it as being Mplayer 1.0rc1_ and hence thinks it is older than the current 1.0rc1_try3:

$ port installed MPlayer
The following ports are currently installed:
MPlayer @1.0rc1_try3+binary_codecs+caca+darwin_8+darwin_powerpc+macosx+osd+x11+xvid (active)

$ port -v outdated MPlayer
The following installed ports are outdated:
MPlayer                        1.0rc1_ < 1.0rc1_try3

Either there is a bug in outdated code, either the use of alphabetic characters in revision should be forbidden.

[ryandesign (Ryan Carsten Schmidt)]

The use of non-integer values in the revision field should be forbidden.

[ryandesign (Ryan Carsten Schmidt)]

So as I said above, it is an error for the revision to be non-numeric.

The MPlayer port's revision was fixed in r27329.

port lint was updated to check for non-numeric revisions (among other things) in r29028.

I checked with

grep -E '^revision[[:space:]]+.*[^[:space:][:digit:]].*$' */*/Portfile

to see if there are any other ports that have non-numeric revisions. The only one is libffi. This came about as a result of r32900. Once Paul fixes that, we can close this ticket.

[tobypeterson]

Milestone MacPorts base bugs deleted