Projects
New Ticket     Wiki     Browse Source     Timeline     Roadmap     Bug Reports     Search

Ticket #12231 (new defect)

Opened 17 months ago

Last modified 15 months ago

BUG: tcl sqlite3 default directory

Reported by: afb@… Owned by: macports-tickets@…
Priority: Normal Milestone: MacPorts base bugs
Component: base Version: 1.5
Keywords: FreeBSD support , Linux support Cc:
Port:

Description

Currentl value (/usr/lib/sqlite3) hardcoded for Darwin, provide some more OS alternatives...

Attachments

macports-tclsqlite3.patch (0.8 KB) - added by afb@… 17 months ago.
macports-tclsqlite3.patch
macports-tclsqlite3.2.patch (1.7 KB) - added by afb@… 15 months ago.
macports-tclsqlite3.patch

Change History

Changed 17 months ago by afb@…

macports-tclsqlite3.patch

Changed 17 months ago by eridius@…

It seems the entire point of this is to provide a sane default for FreeBSD. I'm not sure we want to do this. We've already decided that MacPorts assumes the user is running on Darwin, and so we can rely on Darwin-specific things, like in this case the location of sqlite3. If you want to override it that's what the --with-tcl-sqlite3 configure switch is for. While it doesn't hurt anything to accept this patch for the short term, I'm worried about this setting a precedent that reverses our previous decision.

Anybody else have an opinion?

Changed 17 months ago by landonf@…

I agree that --with-tcl-sqlite3 is the better way to override this on a per-OS basis.

I do disagree on the notion of relying on Darwin-specific paths, as hard-coded paths tend to break ... but in this case, it's just a default, so I don't see an issue.

Changed 17 months ago by afb@…

The only reason for providing defaults was to make "selfupdate" work. As there are no releases since MacPorts 1.4.0, that's the recommended way of installing 1.4.40-42 or the new 1.5/SVN.

Changed 17 months ago by jmpp@…

  • milestone set to Needs developer review

Changed 17 months ago by afb@…

As noted above, the patch doesn't change anything for Mac OS X.

Changed 17 months ago by eridius@…

ok, if this is necessary for selfupdate to work then I'm ok with us accepting the change.

Changed 17 months ago by jmpp@…

  • keywords FreeBSD support added

Changed 16 months ago by jmpp@…

  • milestone changed from Needs developer review to MacPorts base bugs

Milestone Needs developer review deleted

Changed 16 months ago by nox@…

  • priority changed from Expected to Normal
  • summary changed from tcl sqlite3 default directory to BUG: tcl sqlite3 default directory

Changed 15 months ago by afb@…

  • keywords , Linux added

The last clause works on Linux, it seems.

Changed 15 months ago by afb@…

Scratch last comment, each Linux distro has it's own install location. :-(

Configure needs to fall back on the internal version, if no system tcl-sqlite3 can be found. With the current script, you end up with:

SQLITE3_DIR=''
SQLITE3_LIBS='-lsqlite3'

Probably rather useless.

Changed 15 months ago by afb@…

Provided that the sqlite3 libraries are found (but not tcl), it might be possible to use those to build the tcl module with (rather than building the internal/static library)

Changed 15 months ago by afb@…

macports-tclsqlite3.patch

Changed 15 months ago by afb@…

Updated patch to fall back on the internal version, don't seem you can build against system libs.

Note: See TracTickets for help on using tickets.