Opened 17 years ago

Closed 17 years ago

Last modified 14 years ago

#12309 closed enhancement (wontfix)

RFE: Use autoconf on port, portindex, portmirror

Reported by: sfiera@… Owned by: sfiera@…
Priority: Normal Milestone:
Component: base Version:
Keywords: Cc:
Port:

Description

Originally, autoconf variables were used to perform substitution of @TCLSH@ and @TCL_PACKAGE_DIR@. This was changed in r3311, with the explanation that the substitution should be done at compile time rather than configure time. I don't see any particular reason this should be the case, particularly when we're wedging sed in to do a job meant for ./configure.

A patch containing the proposed changes is attached.

Attachments (2)

autoconf.diff (3.1 KB) - added by sfiera@… 17 years ago.
autoconf.patch (3.1 KB) - added by sfiera@… 17 years ago.

Download all attachments as: .zip

Change History (7)

Changed 17 years ago by sfiera@…

Attachment: autoconf.diff added

Changed 17 years ago by sfiera@…

Attachment: autoconf.patch added

comment:1 Changed 17 years ago by landonf (Landon Fuller)

Using make for this purpose ensures that the scripts are re-built when their source is updated. See: http://www.gnu.org/software/autoconf/manual/autoconf-2.57/html_mono/autoconf.html#SEC24

"Similarly you should not rely on AC_OUTPUT_FILES to replace datadir and friends in your shell scripts and other files, rather let make manage their replacement. For instance Autoconf ships templates of its shell scripts ending with `.in', and uses a Makefile snippet similar to ..."

comment:2 Changed 17 years ago by sfiera@…

Resolution: wontfix
Status: newclosed

Good reasoning--Patch retracted.

comment:3 Changed 17 years ago by jmpp@…

Milestone: Needs developer reviewMacPorts base bugs

Milestone Needs developer review deleted

comment:4 Changed 17 years ago by nox@…

Milestone: MacPorts base bugsMacPorts base enhancements
Priority: Not setNormal
Summary: Use autoconf on port, portindex, portmirrorRFE: Use autoconf on port, portindex, portmirror
Version: 1.5.0

comment:5 Changed 14 years ago by jmroot (Joshua Root)

Milestone: MacPorts Future
Note: See TracTickets for help on using tickets.