Opened 17 years ago
Closed 13 years ago
#12314 closed enhancement (fixed)
RFE: ruby-1.8.6 - patch adds a working universal variant
| Reported by: | eloy.de.enige@… | Owned by: | kimuraw (kimura wataru) |
|---|---|---|---|
| Priority: | Low | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | ruby port universal | Cc: | eloy.de.enige@…, pguyot (Paul Guyot), ryandesign (Ryan Carsten Schmidt), febeling@… |
| Port: | ruby ruby186 ruby19 |
Description
This patch adds an extra patchfile which patches ruby 1.8.6 so that it will build universal and patch mkmf.rb so that it will correctly build C extensions that use extconf. The patch also fixes an endian problem when compiling on an intel mac.
The patches are inspired by apple's patches to ruby-1.8.2 but updated for 1.8.6
All tests pass on i386 and ppc.
Attachments (2)
Change History (12)
Changed 17 years ago by eloy.de.enige@…
| Attachment: | ruby_universal.diff added |
|---|
comment:1 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | eloy.de.enige@… ryandesign@… added |
|---|---|
| Milestone: | → Port Enhancements |
comment:2 Changed 17 years ago by eloy.de.enige@…
Sorry to ask a possible dumb question, but what do you mean by "inclusion upstream"?
comment:3 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)
I mean: should any of these patches be delivered to the Ruby developers for inclusion directly in Ruby? There are people using Ruby on Macs who are not using MacPorts. Wouldn't they benefit from this too?
I was also curious to know where you found Apple's patches to ruby-1.8.2.
comment:4 Changed 17 years ago by eloy.de.enige@…
Ah yes, I was thinking about this too indeed. I will have a look at this tomorrow to double check if there's anything that might break a regular ruby installation for non mac users.
Yes the Apple patches are invaluable :) at some point I figured Apple had to put these patches online somewhere... They're available at: http://www.opensource.apple.com/darwinsource/10.4.9.x86/ruby-22.0.1/
Changed 17 years ago by eloy.de.enige@…
| Attachment: | ruby_universal_without_autoconf_dependency.diff added |
|---|
comment:5 Changed 17 years ago by eloy.de.enige@…
Added a new patch which removes the dependency on autoconf and thus on perl (which isn't universal atm), so it should now be possible to have a fresh macports installation and only issue: $port install ruby +universal And all dependencies should be build universal and without the bloat of perl.
Please check if the new patch-configure patch contains anything that it shouldn't contain, because I'm by no means a configure genius.
comment:6 Changed 17 years ago by nox@…
| Priority: | Nice to have → Low |
|---|---|
| Version: | 1.5.0 |
comment:7 Changed 16 years ago by imajes@…
| Owner: | changed from pguyot@… to imajes@… |
|---|---|
| Status: | new → assigned |
will take this onboard for inclusion...
comment:8 Changed 15 years ago by (none)
| Milestone: | Port Enhancements |
|---|
Milestone Port Enhancements deleted
comment:9 Changed 15 years ago by blb@…
| Cc: | febeling@… added |
|---|---|
| Owner: | changed from imajes@… to kimuraw@… |
| Port: | ruby ruby186 ruby19 added |
| Status: | assigned → new |
Assigning/Ccing current ruby, ruby186, and ruby19 maintainers for thoughts.
comment:10 Changed 13 years ago by kimuraw (kimura wataru)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
port:ruby and port:ruby19 work with universal variant now.
Interesting. Do any of these changes need to be submitted for inclusion upstream?