Opened 17 years ago

Closed 16 years ago

Last modified 15 years ago

#12413 closed submission (wontfix)

InsightToolkit - New Port

Reported by: peter@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Insight Toolkit ITK Cc: peter@…, ryandesign (Ryan Carsten Schmidt), nox@…
Port:

Description

This port is loosely based on the VTK port.

Attachments (4)

Portfile (1.1 KB) - added by peter@… 17 years ago.
Portfile.diff (607 bytes) - added by ryandesign (Ryan Carsten Schmidt) 17 years ago.
Portfile.2.diff (649 bytes) - added by peter@… 17 years ago.
Portfile.3.diff (671 bytes) - added by peter@… 17 years ago.
Updated diff of original Portfile

Download all attachments as: .zip

Change History (20)

Changed 17 years ago by peter@…

Attachment: Portfile added

comment:1 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: peter@… ryandesign@… added
  • The line "depends_build bin:cmake:cmake" should be changed to "depends_build port:cmake" because we want to guarantee using the MacPorts cmake port, not some other random version of cmake the user may have installed.
  • The line "configure { system "cd ${worksrcpath} && cmake ${configure.args} ${worksrcpath}" }" could probably be better written "configure.cmd cmake".
  • The above 2 changes apparently also need to be made to the vtk port from which I assume you copied it. If you will confirm that these changes still allow InsightToolkit to build, then I will submit a bug to the author of the vtk portfile.

comment:2 Changed 17 years ago by peter@…

I can confirm that the first change works as expected. However, the second change doesn't work.

When I change the configure directive to "configure.cmd cmake", the build fails with this error:

Error: Target org.macports.configure returned: configure failure: shell command " cd "/opt/local/var/macports/build/_Users_peter_Devel_Macports_science_insighttoolkit/work/InsightToolkit-3.2.0" && cmake --prefix=/opt/local -D BUILD_SHARED_LIBS:BOOL=ON -D CMAKE_INSTALL_PREFIX:PATH=/opt/local " returned error 254

In particular, it appears that something is passing a configure-style "--prefix=/opt/local" directive to cmake. Cmake doesn't take arguments in the format that an autotools configure script does...

I suspect the reason why the VTK port defines the configure command this way is to avoid the autotools style flags. I wonder if Macports has a special directive to set the configure type to a cmake-style configure?

-Peter

comment:3 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)

Ok, the --prefix=/opt/local argument comes from configure.pre_args so you could clear that out. Just use "configure.pre_args" without any value after it.

comment:4 Changed 17 years ago by peter@…

D'oh! So close. One problem remains:

I'm getting the following error now: The source directory "/opt/local/var/macports/build/_Users_peter_Devel_Macports_science_InsightToolkit/work/InsightToolkit-3.2.0/CMAKE_INSTALL_PREFIX:PATH=/opt/local" does not exist.

This implies to me that somehow my configure args and the worksrcpath are getting jammed together.

I'll keep looking unless this is something that someone knows off the top of the head.

-Peter

comment:5 Changed 17 years ago by peter@…

Okay, it appears that it may not have like the unquoted configure.args strings. I single quoted them, and all appears to be well.

Assuming this build goes well (it's a long build), I'll attach an updated Portfile.

comment:6 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)

I just don't like the idea of replacing the configure phase outright. How about the attached diff against your original Portfile?

Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: Portfile.diff added

comment:7 Changed 17 years ago by peter@…

Sorry it's taken me a while to get back to you. It turns out cmake really doesn't like options passed on the command line with a space between the -D flag and the configure option.

I'll include a diff against the original Portfile once I verify that the build is completing and installing to the proper prefix location.

Changed 17 years ago by peter@…

Attachment: Portfile.2.diff added

comment:8 Changed 17 years ago by peter@…

I think this is working now.

comment:9 Changed 17 years ago by nox@…

Version: 1.5.0

cmake dependency should really be specified as bin:cmake:cmake as there is in port tree cmake and cmake-devel.

comment:10 Changed 17 years ago by nox@…

Cc: nox@… added

comment:11 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)

Oh, I see, nox, that makes sense. However, cmake-devel is at 2.4.1 and cmake is at 2.4.6, which is counterintuitive, and makes it seem like cmake-devel is not being used anymore.

comment:12 Changed 17 years ago by peter@…

How should we proceed? Shall I set the cmake dependency line in this package to read bin:cmake:cmake, or will someone remove the aged cmake-devel package?

comment:13 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)

I guess it should depend on path:${prefix}/bin/cmake:cmake so as to pick up any cmake installed by MacPorts, but not any cmake installed by any other means. If the cmake-devel port is deleted, then the dependency could be simplified to just port:cmake.

Changed 17 years ago by peter@…

Attachment: Portfile.3.diff added

Updated diff of original Portfile

comment:14 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: wontfix
Status: newclosed

wontfix this one because a newer version has been submitted in #13932.

comment:15 Changed 15 years ago by jmroot (Joshua Root)

Type: enhancementsubmission

comment:16 Changed 15 years ago by (none)

Milestone: Port Submissions

Milestone Port Submissions deleted

Note: See TracTickets for help on using tickets.