fortune doesn't build under Mac OS X 10.5 Leopard

[mordeth@…]

I can confirm this (Intel Core Duo MacBook Pro). Here is the error text:

[root@dissonance mplayer]# port install fortune
--->  Fetching fortune
--->  Attempting to fetch fortune-6.2.0-RELEASE.tar.bz2 from http://svn.macports.org/repository/macports/distfiles/fortune
--->  Verifying checksum(s) for fortune
--->  Extracting fortune
--->  Applying patches to fortune
--->  Configuring fortune
--->  Building fortune with target all
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_games_fortune/work/fortune" && bsdmake all " returned error 1
Command output: fortune.c:1335: warning: data definition has no type or storage class
fortune.c:1336: error: syntax error before 'while'
fortune.c:1346: error: syntax error before '=' token
fortune.c:1359: warning: type defaults to 'int' in declaration of 'Found_one'
fortune.c:1359: error: conflicting types for 'Found_one'
fortune.c:111: error: previous declaration of 'Found_one' was here
fortune.c:1359: warning: data definition has no type or storage class
fortune.c:1360: warning: type defaults to 'int' in declaration of 'in_file'
fortune.c:1360: error: redefinition of 'in_file'
fortune.c:1335: error: previous definition of 'in_file' was here
fortune.c:1360: warning: data definition has no type or storage class
fortune.c:1361: error: syntax error before '}' token
fortune.c:1362: error: syntax error before '\xa'
fortune.c:1362: warning: type defaults to 'int' in declaration of 'putchar'
fortune.c:1362: warning: data definition has no type or storage class
fortune.c:1363: error: syntax error before 'void'
fortune.c:1365: warning: type defaults to 'int' in declaration of 'sp'
fortune.c:1365: error: redefinition of 'sp'
fortune.c:1334: error: previous definition of 'sp' was here
fortune.c:1365: warning: initialization makes integer from pointer without a cast
fortune.c:1365: error: initializer element is not constant
fortune.c:1365: warning: data definition has no type or storage class
fortune.c:1366: error: syntax error before '}' token
{standard input}:15:FATAL:Symbol _in_file already defined.
*** Error code 1

Stop in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_games_fortune/work/fortune/fortune.
*** Error code 1

Stop in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_games_fortune/work/fortune.

Error: Status 1 encountered during processing.

[rmcintosh@…]

I concur fortune won't build with Leopard on my Intel MBP & a PPC PowerBook as well. Shouldn't the priority of this bug be raised above "normal"?

[afb@…]

Depends on how vital "fortune" is to your every-day functionality :-)

It build and works OK on Tiger, so it's Yet Another Leopard Issue...

[seanrees@…]

buildable port on Leopard

[seanrees@…]

I consider 'fortune' to be pretty vital... :)

Made a few fixes; strfile/strfile.h --> #include <stdint.h> [strfile/strfile.c, unstr/unstr.c, fortune/fortune.c] --> OSSwapHostToBigInt32 -> htonl (from machine/endian.h)

I decided to make new patches for the OSSwapHostToBigInt32 -> htonl on for darwin 9 instead of patching the patch (though I just edited the existing patch files). Not sure of the standard way to approach this :)

Cheers.

[afb@…]

Thanks, <stdint.h> is needed on all platforms and patch should have used "htonl" instead of the Tiger-specific internal function (it was probably broken on Panther as well as on Leopard...)

Applied in r31206.