New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #13025 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

BUG: minicom does not compile

Reported by: bahamat@… Owned by: waqar@…
Priority: Normal Milestone:
Component: ports Version: 1.5.0
Keywords: minicom Cc: bahamat@…, waqar@…, mac@…, sequethin@…
Port:

Description

Output follows:

Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_comms_minicom/work/minicom-2.1" && make all " returned error 2 Command output: Making all in po make[2]: Nothing to be done for `all'. Making all in lib gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/opt/local/include -O2 -c error.c rm -f libport.a ar cru libport.a error.o ranlib libport.a Making all in src gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/opt/local/include -I../lib -O2 -Wall -W -c minicom.c gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/opt/local/include -I../lib -O2 -Wall -W -c vt100.c vt100.c: In function 'vt_init': vt100.c:269: warning: pointer targets in assignment differ in signedness vt100.c:270: warning: pointer targets in assignment differ in signedness vt100.c: In function 'state4': vt100.c:818: warning: pointer targets in assignment differ in signedness vt100.c:822: warning: pointer targets in assignment differ in signedness vt100.c: In function 'state5': vt100.c:844: warning: pointer targets in assignment differ in signedness vt100.c:848: warning: pointer targets in assignment differ in signedness gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/opt/local/include -I../lib -O2 -Wall -W -c config.c gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/opt/local/include -I../lib -O2 -Wall -W -c help.c gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/opt/local/include -I../lib -O2 -Wall -W -c updown.c gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/opt/local/include -I../lib -O2 -Wall -W -c util.c gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/opt/local/include -I../lib -O2 -Wall -W -c dial.c gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/opt/local/include -I../lib -O2 -Wall -W -c window.c window.c:65: error: static declaration of 'BC' follows non-static declaration /usr/include/termcap.h:59: error: previous declaration of 'BC' was here make[2]: *** [window.o] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all-recursive-am] Error 2

Error: Status 1 encountered during processing.

Attachments

minicom_window_patch Download (1.2 KB) - added by gauchi@… 4 years ago.
Workaround to the compilation error. I have no deeper understanding about whether the BC in termcap.h should be identified with the BC in window.c. With this patch applied, they don't. If identification is intended, the program will probably misbehave
minicom-Portfile.patch Download (241 bytes) - added by bahamat@… 4 years ago.
This patches the Portfile for minicom to apply the same patches to "darwin 9" as "darwin 8". This patch will fully resolve this ticket.

Change History

Changed 4 years ago by ryandesign@…

  • cc bahamat@…, waqar@… added
  • owner changed from macports-dev@… to waqar@…
  • milestone set to Port Bugs

Changed 4 years ago by gauchi@…

Workaround to the compilation error. I have no deeper understanding about whether the BC in termcap.h should be identified with the BC in window.c. With this patch applied, they don't. If identification is intended, the program will probably misbehave

Changed 4 years ago by ryandesign@…

  • cc mac@…, sequethin@… added

Changed 4 years ago by waqar@…

  • status changed from new to assigned

Changed 4 years ago by bahamat@…

This patches the Portfile for minicom to apply the same patches to "darwin 9" as "darwin 8". This patch will fully resolve this ticket.

Changed 4 years ago by bahamat@…

Please commit the patch I just added to the repository so this ticket can be closed.

Changed 4 years ago by waqar@…

---> Applying patches to minicom Error: Target org.macports.patch returned: shell command " cd "/opt/local/var/macports/build/_opt_macports_dports_comms_minicom/work/minicom-2.1" && patch -p0 < '/opt/macports/dports/comms/minicom/files/patch-window.c'" returned error 1 Command output: can't find file to patch at input line 3 Perhaps you used the wrong -p or --strip option? The text leading up to this was:


|--- window.c 2003-05-16 22:06:26.000000000 +0200 |+++ ../../window.c 2007-11-06 09:11:08.000000000 +0100


File to patch: Skip this patch? [y] Skipping patch. 4 out of 4 hunks ignored

Error: Status 1 encountered during processing.

Changed 4 years ago by bahamat@…

This patch needs to be applied to the Portfile. After applying this patch to the Portfile, then run "port install minicom".

Changed 4 years ago by jmr@…

  • status changed from assigned to closed
  • resolution set to fixed

It appears that this was fixed in r33161.

Changed 3 years ago by anonymous

  • milestone Port Bugs deleted

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.