New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #13027 (closed submission: fixed)

Opened 6 years ago

Last modified 4 years ago

NEW: rsyncrypto 1.06

Reported by: macports@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: ryandesign@…, ecronin@…, vincent@…
Port: rsyncrypto

Description

rsyncrypto encrypts files in a way that shouldn't mess up rsync's change detection.

It was a pretty easy portfile, though I've only tested it on my own computer.

Attachments

Portfile (982 bytes) - added by macports@… 6 years ago.
Revised per recommendations
Portfile.2 (1.0 KB) - added by ecronin@… 5 years ago.
update of Portfile for version 1.06
Portfile.3 (1.1 KB) - added by macports@… 5 years ago.
rsyncrypto 1.12

Change History

comment:1 Changed 6 years ago by ryandesign@…

  • Cc ryandesign@… added
  • Owner changed from macports-dev@… to ryandesign@…

Thanks for contributing! There are some problems though:

$ sudo port lint
--->  Verifying Portfile for rsyncrypto
Warning: Line 4 should be a newline (after PortSystem)
Error: Missing required variable: homepage
Warning: Using full email address for no/open maintainer
--->  1 errors and 2 warnings found.
$

So please:

  • add a newline after the PortSystem line
  • add a line for the homepage, and
  • list yourself as the maintainer (or put just "nomaintainer" if you do not want to maintain the port)

In addition:

  • master_sites should not contain the archive name; just list the directory. In this case, you probably want "master_sites sourceforge" instead.
  • You probably want to use "configure.cppflags-append" instead of "configure.env CPPFLAGS="
  • Why are you fiddling with the compiler in the platform darwin 8 section? gcc4 is already the default compiler on Mac OS X 10.4 (and 10.5) so you shouldn't need to do this unless rsyncrypto is weird.

Can you please attach a revised portfile? Thanks.

Changed 6 years ago by macports@…

Revised per recommendations

comment:2 Changed 6 years ago by macports@…

I attempted to incorporate the recommendations. I started with an existing portfile, which may have required a less conventional configuration.

Not quite sure what I'm getting myself into with maintenance, but I'll give it go.

  • Justin

comment:3 follow-up: ↓ 7 Changed 5 years ago by ecronin@…

  • Version 1.5.2 deleted
  • Summary changed from NEW: rsyncrypto 1.04 to NEW: rsyncrypto 1.06

Hi, going through unclosed port submissions in trac and this one looks good now with one exception:

checking for gzip with "rsyncable" support... gzip: unrecognized option `--rsync
able'
Try `gzip --help' for more information.
no!
configure: WARNING: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
configure: WARNING: ! gzip must support the "--rsyncable" flag for proper rsyncrypto operation.         !
configure: WARNING: ! This does not affect compilation, but a proper gzip must be available at runtime. !
configure: WARNING: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

From the README:

Rsyncrypto requires gzip that supports the "rsyncable" flag. The gzip rsyncable
flag is a patch written by Rusty Russell. This patch is available in the
"contrib" directory, and nees to be applied against the *gzip* sources.

So it looks like either the build of rsyncrypto needs to fetch/build/install a gzip-rsyncable binary or add a +rsyncable variant to archivers/gzip which fetches the rsyncrypto port to grab and apply the patch in contrib.

I'm attaching an updated portfile which bumps it to the current 1.06 version

Changed 5 years ago by ecronin@…

update of Portfile for version 1.06

comment:4 Changed 5 years ago by ecronin@…

  • Cc ecronin@… added

comment:5 Changed 5 years ago by jmpp@…

  • Cc macports-dev@… removed

comment:6 Changed 5 years ago by ryandesign@…

  • Priority changed from Low to Normal
  • Cc vincent@… added

comment:7 in reply to: ↑ 3 Changed 5 years ago by macports@…

Replying to ecronin@…:

configure: WARNING: ! gzip must support the "--rsyncable" flag for proper rsyncrypto operation. !

The gzip port supports variant +rsyncable with r39748. I've freshened rsyncrypto to 1.12 and updated the description to mention the required variant.

Changed 5 years ago by macports@…

rsyncrypto 1.12

comment:8 Changed 5 years ago by blb@…

  • Status changed from new to closed
  • Cc macports@… removed
  • Resolution set to fixed
  • Port set to rsyncrypto

Port added in r41561, thanks. Note I did make one change, obfuscating your email with the a@… -> b.c:a technique (port info knows how to de-obfuscate this).

comment:9 Changed 4 years ago by jmr@…

  • Type changed from enhancement to submission

comment:10 Changed 4 years ago by anonymous

  • Milestone Port Submissions deleted

Milestone Port Submissions deleted

Note: See TracTickets for help on using tickets.