Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#13195 closed defect (fixed)

dialog does weird things with its distfile

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: jyrkiwahlstedt
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc: jyrkiwahlstedt, ryandesign (Ryan Carsten Schmidt), nox@…
Port:

Description

The dialog portfile goes through considerable hoops to rename the distfile to a versioned name after build, and back to an unversioned name before build. It would be so much simpler to just use the dist_subdir variable, wouldn't it? See the patch.

Attachments (1)

dialog-dist_subdir.diff (878 bytes) - added by ryandesign (Ryan Carsten Schmidt) 16 years ago.
a much simpler way to do it

Download all attachments as: .zip

Change History (5)

Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: dialog-dist_subdir.diff added

a much simpler way to do it

comment:1 Changed 16 years ago by nox@…

Cc: nox@… added

I would say it would be better to contact upstream to ask them to provide a versioned tarball, or just host it ourselves.

comment:2 Changed 16 years ago by afb@…

distfiles and files should be consider read-only, as far as Portfiles are concerned.

If anything needs to be modified (probably doesn't here), it should happen in work...

comment:3 Changed 16 years ago by jyrkiwahlstedt

Resolution: fixed
Status: newclosed

Portfile changed in r30851 (though upstream change would be better)

comment:4 Changed 15 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.