XMMS2 Portfile

[tru@…]

I have made a XMMS2 port. This is the first port I ever make, so I welcome all feedback.

Here we go:

# $Id$

PortSystem 1.0
name            xmms2
version         0.4DrKosmos
revision        0
categories      audio
maintainers     nomaintainer
description     Client/server based media player system
homepage        http://xmms2.xmms.org/
platforms       darwin
master_sites    http://dfn.dl.sourceforge.net/sourceforge/xmms2/ #xmms2-0.4DrKosmos.tar.bz2
use_bzip2       yes
depends_lib     port:glib2 port:sqlite3 port:libmad port:libvorbis port:libogg port:boost
depends_build port:python24

checksums       md5 f363857a77606a2d7d14603ab375f454
long_description Audio player

configure {
        cd ${worksrcpath}
        system "./waf configure --conf-prefix=${prefix} --prefix=${prefix}"
}

build {
        cd ${worksrcpath}
        system "./waf build"
}

destroot {
        cd ${worksrcpath}
        system "./waf install --destdir=${destroot}"
}

[nox@…]

Some comments:

• $version should really be set to 0.4, as it doesn't make any sense to have some joke wandering alone in the version string.
• You don't need to explicitely set $revision to 0.
• Instead of writing custom configure/build/destroot stages, you should rather do

  configure.cmd       ./waf
  configure.args      --conf-prefix=${prefix}
  
  build.cmd           ./waf
  
  destroot.cmd        ./waf
  destroot.destdir    --destdir=${destroot}    
  

[nox@…]

Sorry, I meant:

configure.cmd   ./waf configure
build.cmd       ./waf build
destroot.cmd    ./waf install

[tru@…]

Replying to nox@macports.org:

Some comments: * $version should really be set to 0.4, as it doesn't make any sense to have some joke wandering alone in the version string.

It's actually not a joke. DR = Developer Release, and the names after are in sequential order. Next version will be named 0.4DrL ... something.

* You don't need to explicitely set $revision to 0. * Instead of writing custom configure/build/destroot stages, you should rather do {{{ configure.cmd ./waf configure.args --conf-prefix=${prefix} build.cmd ./waf destroot.cmd ./waf destroot.destdir --destdir=${destroot} }}}

Thanks for your suggestions, here is the updated portfile:

# $Id$

PortSystem 1.0
name		xmms2
version		0.4DrKosmos
categories	audio
maintainers	nomaintainer
description	CrossPlatform Music Multiplexer System
homepage	http://xmms2.xmms.org/
platforms	darwin
master_sites    http://dfn.dl.sourceforge.net/sourceforge/xmms2/ #xmms2-0.4DrKosmos.tar.bz2
use_bzip2	yes
depends_lib	port:glib2 port:sqlite3 port:libmad port:libvorbis port:libogg port:boost
depends_build port:python24

checksums	md5 f363857a77606a2d7d14603ab375f454
long_description Audio player

configure.cmd ./waf configure
configure.args --conf-prefix=${prefix} --prefix=${prefix}

build.cmd ./waf build
build.target 

destroot.cmd ./waf install
destroot.args --destdir=${destroot}
destroot.target  
destroot.destdir

[nox@…]

Is the python24 build dependency mandatory, or does it only need a python interpreter, whatever the version?