Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#13356 closed submission (fixed)

XMMS2 Portfile

Reported by: tru@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.5.2
Keywords: Cc: nox@…
Port: xmms2

Description

I have made a XMMS2 port. This is the first port I ever make, so I welcome all feedback.

Here we go:

# $Id$

PortSystem 1.0
name            xmms2
version         0.4DrKosmos
revision        0
categories      audio
maintainers     nomaintainer
description     Client/server based media player system
homepage        http://xmms2.xmms.org/
platforms       darwin
master_sites    http://dfn.dl.sourceforge.net/sourceforge/xmms2/ #xmms2-0.4DrKosmos.tar.bz2
use_bzip2       yes
depends_lib     port:glib2 port:sqlite3 port:libmad port:libvorbis port:libogg port:boost
depends_build port:python24

checksums       md5 f363857a77606a2d7d14603ab375f454
long_description Audio player

configure {
        cd ${worksrcpath}
        system "./waf configure --conf-prefix=${prefix} --prefix=${prefix}"
}

build {
        cd ${worksrcpath}
        system "./waf build"
}

destroot {
        cd ${worksrcpath}
        system "./waf install --destdir=${destroot}"
}

Change History (10)

comment:1 Changed 16 years ago by afb@…

Milestone: Port Submissions

comment:2 Changed 16 years ago by nox@…

Cc: nox@… added

Some comments:

  • $version should really be set to 0.4, as it doesn't make any sense to have some joke wandering alone in the version string.
  • You don't need to explicitely set $revision to 0.
  • Instead of writing custom configure/build/destroot stages, you should rather do
    configure.cmd       ./waf
    configure.args      --conf-prefix=${prefix}
    
    build.cmd           ./waf
    
    destroot.cmd        ./waf
    destroot.destdir    --destdir=${destroot}    
    

comment:3 Changed 16 years ago by nox@…

Sorry, I meant:

configure.cmd   ./waf configure
build.cmd       ./waf build
destroot.cmd    ./waf install

comment:4 in reply to:  2 Changed 16 years ago by tru@…

Replying to nox@macports.org:

Some comments:

  • $version should really be set to 0.4, as it doesn't make any sense to have some joke wandering alone in the version string.

It's actually not a joke. DR = Developer Release, and the names after are in sequential order. Next version will be named 0.4DrL ... something.

  • You don't need to explicitely set $revision to 0.
  • Instead of writing custom configure/build/destroot stages, you should rather do
    configure.cmd       ./waf
    configure.args      --conf-prefix=${prefix}
    
    build.cmd           ./waf
    
    destroot.cmd        ./waf
    destroot.destdir    --destdir=${destroot}    
    

Thanks for your suggestions, here is the updated portfile:

# $Id$

PortSystem 1.0
name		xmms2
version		0.4DrKosmos
categories	audio
maintainers	nomaintainer
description	CrossPlatform Music Multiplexer System
homepage	http://xmms2.xmms.org/
platforms	darwin
master_sites    http://dfn.dl.sourceforge.net/sourceforge/xmms2/ #xmms2-0.4DrKosmos.tar.bz2
use_bzip2	yes
depends_lib	port:glib2 port:sqlite3 port:libmad port:libvorbis port:libogg port:boost
depends_build port:python24

checksums	md5 f363857a77606a2d7d14603ab375f454
long_description Audio player

configure.cmd ./waf configure
configure.args --conf-prefix=${prefix} --prefix=${prefix}

build.cmd ./waf build
build.target 

destroot.cmd ./waf install
destroot.args --destdir=${destroot}
destroot.target  
destroot.destdir


comment:5 Changed 16 years ago by nox@…

Owner: changed from macports-tickets@… to nox@…

Is the python24 build dependency mandatory, or does it only need a python interpreter, whatever the version?

comment:6 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Port: xmms2 added

comment:7 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from nox@… to ryandesign@…
Status: newassigned

comment:8 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

I finally added an xmms2 port in r40167. I based it on the one submitted by tru in comment 4 but made lots of changes, including upping the version from 0.4 to 0.5, adding a mess of dependencies on things with which xmms2 linked on my system, and explicitly naming the plugins and optionals we want enabled (to prevent it from linking with other ports the user might happen to have installed). I also upped the python dependency from 2.4 to 2.5 since that's the latest stable version. xmms2 does not build with python30.

comment:9 Changed 15 years ago by jmroot (Joshua Root)

Type: enhancementsubmission

comment:10 Changed 15 years ago by (none)

Milestone: Port Submissions

Milestone Port Submissions deleted

Note: See TracTickets for help on using tickets.