Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#13363 closed enhancement (fixed)

mutt-devel 1.5.17 no longer has variant "trash"

Reported by: kuperman@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.5.2
Keywords: mutt, mail, mutt-devel, trash Cc: jmroot (Joshua Root)
Port:

Description

Previous versions of mutt-devel included the variant "trash" that added in 2 patches "trash" and "purge" both by Cedric Duval. This latest update of the Portfile dropped them. I found them to be quite useful and would love to have them added back into the port rather than needing to compile my own version.

If the issue is that the patches are out of date, I'd be willing to work on updating them. I know at least one of them has been updated for 1.5.16 (http://scie.nti.st/dist/trash-1.5.16.patch.txt)

Attachments (1)

patch-1.5.17.cd.purge_message.bk.1 (6.9 KB) - added by kuperman@… 16 years ago.
Purge patch (needs trash patch to already be applied)

Download all attachments as: .zip

Change History (12)

comment:1 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: olaf@… added

Cc'ing maintainer. The trash variant was removed through #13219.

comment:2 Changed 16 years ago by olaf@…

AFAIR they didn't compile OOTB. If you would provide patches I will be happy to include them.

Changed 16 years ago by kuperman@…

Purge patch (needs trash patch to already be applied)

comment:3 Changed 16 years ago by kuperman@…

The above trash patch seems to apply itself fine http://scie.nti.st/dist/trash-1.5.16.patch.txt and I've attached my updated version of the purge patch.

Here's what I included in the portfile after having specified a local path for the patch file. I can also host the two patches if that would be preferred.

variant trash {
    patch_sites-append http://scie.nti.st/dist/
    patchfiles-append trash-1.5.16.patch.txt
    checksums-append trash-1.5.16.patch.txt md5 \
                     d0bc85f30ba298472dcda47dae825b19

    patchfiles-append patch-1.5.17.cd.purge_message.bk.1
    checksums-append patch-1.5.17.cd.purge_message.bk.1 md5 \
                     4e26858e9fe2eb96211714a3e3f55d88
}

I renamed the patch so it differs from the original, but I don't know what the appropriate naming scheme for such would be.

comment:4 Changed 16 years ago by jmroot (Joshua Root)

Cc: jmr@… added

We can add the patch files to the ports tree, no need to download them from an external site. The naming scheme for patch files is "patch-*.diff".

Olaf, can you confirm that these patches are OK?

comment:5 Changed 16 years ago by jmroot (Joshua Root)

Cc: olaf@… removed

Olaf is no longer maintaining this port.

comment:6 Changed 16 years ago by jmroot (Joshua Root)

Committed in r34543. Could you please check that the variant works?

comment:7 Changed 16 years ago by kuperman@…

I've been testing the variant for the past couple of days and everything seems to be working just fine.

comment:8 Changed 16 years ago by reiffert@…

So can we close the ticket then?

comment:9 Changed 16 years ago by kuperman@…

Fine by me. I've not tested any combinations of variants, just the one that I use. But I suppose if someone else finds a conflict later they'll open a new ticket.

comment:10 Changed 16 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed

Thanks for testing. Marking fixed.

comment:11 Changed 15 years ago by (none)

Milestone: Port Enhancements

Milestone Port Enhancements deleted

Note: See TracTickets for help on using tickets.