New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #13493 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

xorg-renderproto and render conflict

Reported by: mww@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.5.2
Keywords: render xorg-renderproto xorg Cc: bbyer@…, mww@…, ryandesign@…, nox@…, jwa@…, stechert@…, mcalhoun@…, macsforever2000@…
Port: xorg-renderproto, render

Description

xorg-renderproto and render conflict in

${prefix}/include/X11/extensions/render.h
${prefix}/include/X11/extensions/renderproto.h

could we remove render for xorg-renderproto or ... ?

Change History

  Changed 3 years ago by ryandesign@…

  • cc ryandesign@… added
  • port set to xorg-renderproto, render

"render" and "xorg-renderproto" are the same software. We should fix up all ports that depend on "render" (change them to depend on "xorg-renderproto" instead) and then delete "render".

"render" installs some documentation files that "xorg-renderproto" does not. "xorg-renderproto" should be updated to install those documentation files.

  Changed 3 years ago by ryandesign@…

"xorg-renderproto" should also use "universal_variant no" like "render" does.

  Changed 3 years ago by blb@…

I don't think there's much in the render docs that's really needed, the doc for the extension itself is the only document xorg-renderproto installs, and that's probably all that's really needed.

  Changed 3 years ago by nox@…

  • cc nox@… added

Cc Me!

  Changed 3 years ago by nox@…

  • cc jwa@…, stechert@… added

Affected ports:

  • devel/libgdiplus (stechert)
  • gnome/gthumb (nomaintainer)
  • graphics/cairo (ryandesign)
  • graphics/cairo-devel (ryandesign)
  • x11/gtk2 (nox openmaintainer)
  • x11/rxvt-unicode (nomaintainer)
  • x11/wine (ryandesign jwa openmaintainer)
  • x11/wine-devel (ryandesign jwa openmaintainer)
  • x11/xrender (nomaintainer)

  Changed 3 years ago by mcalhoun@…

  • cc mcalhoun@… added

Cc Me!

  Changed 3 years ago by ryandesign@…

cairo fixed in r41758

  Changed 3 years ago by ryandesign@…

cairo-devel fixed in r41764

wine and wine-devel fixed in r41765

follow-up: ↓ 11   Changed 3 years ago by blb@…

So how are we going to handle

DEBUG: Executing org.macports.activate (xorg-renderproto)
Error: Target org.macports.activate returned: Image error: /opt/local/include/X11/extensions/render.h is being used by the active render port.  Please deactivate this port first, or use the -f flag to force the activation.
Error: Status 1 encountered during processing.

  Changed 3 years ago by ryandesign@…

Replying to ryandesign@…:

"xorg-renderproto" should also use "universal_variant no" like "render" does.

Committed in r41766 (maintainer timeout)

in reply to: ↑ 9   Changed 3 years ago by ryandesign@…

Replying to blb@…:

So how are we going to handle :Error: Target org.macports.activate returned: Image error: /opt/local/include/X11/extensions/render.h is being used by the active render port. Please deactivate this port first, or use the -f flag to force the activation."

Once the affected ports depend on xorg-renderproto instead of render, we should increment render's revision and modify it to install no files and output a message advising users to uninstall it.

  Changed 3 years ago by ryandesign@…

rxvt-unicode fixed in r41767

  Changed 3 years ago by ryandesign@…

xrender fixed in r41771

  Changed 3 years ago by ryandesign@…

gtk2 fixed in r41777

  Changed 3 years ago by ryandesign@…

cairo and cairo-devel really fixed in r41778

  Changed 3 years ago by ryandesign@…

gthumb fixed in r41782

  Changed 3 years ago by ryandesign@…

libgdiplus fixed in r41784. My apologies to Andre Stechert; I realize I didn't give him the full 72 hours we usually give maintainers to respond, but I need to fix these ports now so that we can fix the render port so it installs no files, so users might have a smoother upgrade transition. I also recall Andre's past statements that his ports should be considered openmaintainer, and reference ticket #17108 where I invoked the maintainer timeout for this port earlier today.

  Changed 3 years ago by ryandesign@…

  • status changed from new to closed
  • resolution set to fixed

render fixed in r41785: it now installs no files (except a readme, since all ports must install at least one file) and outputs a message telling the user they can uninstall the port. That should do it!

  Changed 3 years ago by ryandesign@…

r41802: Changed render to not issue that message quite yet. Added render as a dependency to xorg-renderproto. This will hopefully allow users to transition from render to xorg-renderproto without seeing any conflicts between render and xorg-renderproto, since render will be forced to be upgraded first to the version that installs no files. See  this message on macports-users.

  Changed 3 years ago by ryandesign@…

  • status changed from closed to reopened
  • resolution fixed deleted

Sigh, this is still not working right.

If you don't already have xorg-renderproto installed (which you probably don't), then MacPorts wants to install xorg-renderproto (as opposed to upgrade xorg-renderproto). But when installing, MacPorts doesn't check whether dependencies should be upgraded. It only checks for that when upgrading. So, MacPorts sees xorg-renderproto has a render dependency, sees that (an older version of) render is already installed, and thinks that's ok. It's totally not though.

With reluctance, adding render back in as a dependency of all ports that it was a dependency of before, in r41828. This can be removed later once everyone has upgraded. (When will that be?)

  Changed 3 years ago by macsforever2000@…

  • cc macsforever2000@… added

Cc Me!

follow-up: ↓ 23   Changed 3 years ago by mcalhoun@…

Please forgive my ignorance, but why do some ports (such as gtk2) depend on both xrender and xorg-renderproto?
Shouldn't they simply depend on xrender and let xrender worry about render vs xorg-renderproto?

in reply to: ↑ 22   Changed 3 years ago by ryandesign@…

Replying to mcalhoun@…:

Please forgive my ignorance, but why do some ports (such as gtk2) depend on both xrender and xorg-renderproto?
Shouldn't they simply depend on xrender and let xrender worry about render vs xorg-renderproto?

Sounds sensible to me. Anybody see anything wrong with that? I would remove render and xorg-renderproto as dependencies from all ports on jmr's list above, except xrender, which should keep both until a time in the future when we can assume everyone has upgraded, and also until after everyone has upgraded to MacPorts 1.7.0 which has the fix that properly removes removed dependencies from the receipts or wherever it's stored...

follow-up: ↓ 25   Changed 3 years ago by mcalhoun@…

So far, there have been no objections to the above comment.
May I go ahead and remove dependencies on xorg-renderproto and render on the owned ports which depend on xrender?

in reply to: ↑ 24   Changed 3 years ago by ryandesign@…

Replying to mcalhoun@…:

May I go ahead and remove dependencies on xorg-renderproto and render on the owned ports which depend on xrender?

Go for it!

  Changed 3 years ago by mcalhoun@…

Change made in r42478.

  Changed 3 years ago by mcalhoun@…

  • status changed from reopened to closed
  • resolution set to fixed

render was removed in r44924.

  Changed 3 years ago by anonymous

  • milestone Port Bugs deleted

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.