New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #13496 (closed defect: fixed)

Opened 4 years ago

Last modified 2 years ago

Lint complains if first line of Portfile is modeline

Reported by: rhwood@… Owned by: macports-tickets@…
Priority: Normal Milestone: MacPorts 1.7.0
Component: base Version: 1.6.0
Keywords: lint modeline Cc:
Port:

Description

For port gtk2, lint produces the following:

--->  Verifying Portfile for gtk2
Warning: Line 1 is missing RCS tag ($Id$)
--->  0 errors and 1 warnings found.

The first line of the port is a modeline.

Perhaps lint should be changed to recognize that if the 1st line is a modeline that the first three lines of the portfile should be:

modeline an empty line for readability the RCS tag

In addition, can lint recognize that the modeline is/or is not the standard modeline?

Change History

Changed 4 years ago by rhwood@…

modeline an empty line for readability the RCS tag

should read:

modeline
an empty line for readability
RCS tag

Changed 4 years ago by milosh@…

Are modeline and RCS tags supposed to be readable by humans? I don't think they need to stand out this much and hence don't need an empty line between them.

Changed 4 years ago by afb@…

  • summary changed from Lint complains if first line of Portfile is a modeline to Lint complains if first line of Portfile is a newline

port lint does recognize the modeline gunk, it just doesn't like the newline between it and RCS... However, the error seems to be wrong, as it should be "Line 2 is missing RCS tag".

Changed 4 years ago by ryandesign@…

  • summary changed from Lint complains if first line of Portfile is a newline to Lint complains if first line of Portfile is modeline

Changed 4 years ago by afb@…

  • status changed from new to closed
  • resolution set to fixed

Fixed, r32480.

Changed 3 years ago by toby@…

  • milestone changed from MacPorts base bugs to MacPorts Future

Milestone MacPorts base bugs deleted

Changed 2 years ago by jmr@…

  • milestone changed from MacPorts Future to MacPorts 1.7.0
Note: See TracTickets for help on using tickets.