asterisk - new port submission

[marc.blanchet@…]

new port submission asterisk: An Open Source PBX and telephony toolkit  http://www.asterisk.org port tested on tiger and leopard.

[ecronin@…]

Two comments-

First, any reason why the build.env changes should use the already existing MacPorts $CFLAGS and $LDFLAGS (which may include additional default flags)

And second, while the "let ./configure figure it out" approach is easier it means you'll almost certainly end up with incorrect dependencies which is bad. Take a look at the equally painful multimedia/MPlayer port, which explicitly disables auto-detection of anything not a default dependency and includes the most common options by default.

[marc.blanchet@…]

1) AST*FLAGS is a trick done by Asterisk builder to preserve flags during the multiple stages. It was put there because of some build issues on embedded systems. I've tried to cut it in many ways, but did not succeed without this portfile config.

2) humm. I see (Mplayer portfile). I understand the "full control" approach on the port side. However, it is much more work on creating and specially maintaining the portfile. The main disadavantage being lack of time or delay to make the changes to the portfile when a new release of asterisk is out.

suggestion: - start as it is. - if we find issues, then I'll look at the "full control" approach.

[ecronin@…]

Sorry, what I meant for the first point is that instead of hard-coding in a particular CFLAGS, why not use the defaults MacPorts already sets (configure.cflags, configure.cppflags, configure.ldflags). Similarly,

configure.cflags-append -I${prefix}/include
configure.ldflags-append -L${prefix}/lib

are probably not needed (or at least not ldflags for sure) since MacPorts starts out with

default configure.cppflags  {"-I${prefix}/include"}
default configure.ldflags   {"-L${prefix}/lib"}

[marc.blanchet@…]

it seems to now work without, and I can't recall in which circumstances I needed it. so I'll update the portfile without the configure.*-append.

[marc.blanchet@…]

ports/net/asterisk Portfile

[markd@…]

Don't you need some codecs and other stuff for asterisk to work?

[ecronin@…]

Destroot is not succeeding for me- it installs directly under ${prefix} both with and without the -t flag to port to enable trace mode. port uninstall then leaves all the files around (sudo rm -rf /opt/local/var/lib/asterisk /opt/local/lib/asterisk/modules /opt/local/etc/asterisk /opt/local/var/spool/asterisk /opt/local/sbin/rasterisk /opt/local/sbin/asterisk /opt/local/sbin/astgenkey /opt/local/sbin/autosupport /opt/local/sbin/safe_asterisk /opt/local/include/asterisk /opt/local/include/asterisk.h /opt/local/lib/asterisk /opt/local/share/man/man8/asterisk.8 /opt/local/share/man/man8/safe_asterisk.8 cleans up after it I think)

I would still recommend addressing the dependency issues sooner rather than later... Binary packages/installs won't work, and it may break unexpectedly down the line for random users when an undetected library dependency gets updated. On my install it seemed to have picked up libtool, gawk, libogg, popt, speex, libusb, libvorbis, pkgconfig, libxml2, and libxslt. Some of those seem like things you'd want variants for, but some like libtool/popt/pkgconfig seem like actual dependencies for a vanilla build. Also, the one dependency in the Portfile, wget, doesn't seem to be used anywhere in the build.

[marc.blanchet@…]

codecs: most codecs are included. some patent-protected ones (G729) require a binary license module which is not available on macosx. therefore, nothing special to do about codecs.

dependencies: wget is used when installing to get additional sound files from the net.

[mr_bond@…]

Added portfile for 1.4.19.1. Testing it before commiting

[mr_bond@…]

Closed by r36342

[anonymous]

Milestone Port Submissions deleted