New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #13804 (closed enhancement: fixed)

Opened 4 years ago

Last modified 3 years ago

osxvnc: allow non-universal build

Reported by: anton@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc: anton@…, nox@…, jmr@…
Port:

Description

Sometimes the extra weight of universal builds is unneeded. This package, by default, builds universal. Attached is a patch that retains this behavior, but allows variant -universal to build an arch specific binary.

Attachments

osxvnc_-universal.patch Download (0.7 KB) - added by anton@… 4 years ago.

Change History

Changed 4 years ago by anton@…

Changed 4 years ago by ryandesign@…

  • cc changed from anton@bladehawke.com,nox@macports.org to anton@bladehawke.com, nox@macports.org
  • owner changed from macports-tickets@… to ryandesign@…
  • milestone set to Port Enhancements

Changed 4 years ago by nox@…

You don't need to use uname -m here, just use $(NATIVE_ARCH) and  xcodebuild will be happy.

Changed 4 years ago by jmr@…

IMO it would be better to remove universal as a default variant, like other ports:

variant universal {}
if { [variant_isset universal] } {
    xcode.build.settings ARCHS='i386 ppc'
} else {
    xcode.build.settings ARCHS=$(NATIVE_ARCH)
}

Changed 4 years ago by ryandesign@…

  • status changed from new to closed
  • resolution set to fixed
  • summary changed from osxvnc: -universal variant to osxvnc: allow non-universal build

I'm happy to change osxvnc so that universal is not the default. I just didn't know exactly how to do it.

"xcode.build.settings ARCHS=$(NATIVE_ARCH)" is not the solution; the port self-destructs with the message "can't read "(NATIVE_ARCH)": no such variable".

"xcode.build.settings ARCHS=\$(NATIVE_ARCH)" isn't it either; this passes $(NATIVE_ARCH) on to the xcodebuild line, but that then complains with "sh: line 1: NATIVE_ARCH: command not found"

"xcode.build.settings ARCHS=\\\$\\(NATIVE_ARCH\\)" gets past the errors and the build completes, but still ends up being universal.

I'm not keen on calling out to uname -m...

I'll do it the way Anthony Ramine has been doing in his ports for some time. Committed in r35717. Thanks for all the suggestions though!

No revision bump is necessary. Users who had the port installed previously automatically had the +universal variant selected. Users who now install the port will get it without +universal, but can select +universal if they want it.

Changed 4 years ago by ryandesign@…

  • cc jmr@… added

Changed 3 years ago by anonymous

  • milestone Port Enhancements deleted

Milestone Port Enhancements deleted

Note: See TracTickets for help on using tickets.