New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #13825 (new defect)

Opened 5 years ago

Last modified 4 years ago

port lint should check non-selected variants and platforms

Reported by: ryandesign@… Owned by: macports-tickets@…
Priority: Normal Milestone: MacPorts Future
Component: base Version: 1.6.0
Keywords: Cc:
Port:

Description

port lint checks patchfile names (see #12958) but only in variants or platforms which are selected. For example, if a portfile includes

platform darwin 6 {
	patchfiles foo
}

and one is not running Mac OS X 10.2, then no warning is issued for the patchfile foo, though one should be. Or if a portfile includes

variant abc description abc {
	patchfiles bar
}

and one does not run sudo port lint +abc (and +abc is not a default variant), then no warning issued for the patchfile bar, though one should be.

Change History

comment:1 Changed 5 years ago by afb@…

  • Summary changed from port lint should check patchfile names in non-selected variants and platforms to port lint should check non-selected variants and platforms

Proabably should be made more generic, so that it runs all checks on inactive variants ?

comment:2 Changed 5 years ago by ryandesign@…

Of course. I mean, one phase of lint simply does a line-by-line check of the portfile, so that phase already checks inactive variants. But whatever the second phase does (including checking patchfiles as reported in this ticket and checking port dependencies as reported in #14380) should check inactive variants as well, somehow.

comment:3 Changed 4 years ago by toby@…

  • Milestone changed from MacPorts base bugs to MacPorts Future

Milestone MacPorts base bugs deleted

Note: See TracTickets for help on using tickets.