New Port qmail-spamcontrol

[compconsultant@…]

This is a port of the qmail smtp server along with the spamcontrol patches. Qmail is the second most popular MTA on the internet.

Qmail has a old restrictive license, and, when combined with patches, is fairly convoluted as far as how to compile and install. So, this port tried to follow all of the conventions while still following the license. I understand the licensing has recently changed and hopefully, a future version will be simpler.

[ryandesign@…]

There are many things I want to change about this port, but I'll start by committing it just as you submitted it, in r33386. Then I'll make some changes.

[ryandesign@…]

r33387: fixed names of patchfiles; see port lint

[ryandesign@…]

r33388: don't hard-code "/opt/local"; MacPorts could be installed in any prefix.

[ryandesign@…]

r33389: removed trailing whitespace in Portfile; see port lint

[ryandesign@…]

r33390: refine the readme and post-install messages

[ryandesign@…]

r33391: remove the comment about requiring 10.3; add an error message for users running 10.2

[ryandesign@…]

r33392: simplify the creation of the required empty directories

[ryandesign@…]

r33393: use ${name} where appropriate instead of re-typing the port name

[ryandesign@…]

r33394: more minor changes to the readme

[ryandesign@…]

r33395: simplify installation of example files with xinstall and a for loop and give the scripts an execute bit

[ryandesign@…]

r33396: simplify the rest of the post-destroot using xinstall too

[ryandesign@…]

r33398: remove unnecessary escaping in reinplace making it hard to read

[ryandesign@…]

r33399: turn off universal variant since it doesn't seem to work. If you can provide a solution to build this software universal, that would of course be better.

[ryandesign@…]

r33400: fix livecheck

[ryandesign@…]

Ok! First of all thank you for your submission. I think I've made all the changes I'm going to make for now. The original version of the Portfile was 18,248 bytes, 366 lines. After all the above changes, the new Portfile is 8331 bytes, 251 lines. Much better!

These questions remain:

• Could you create a description for each variant please? (port lint reminds you to do this.)
• The definition of PATH at the top of qmailctl includes /bin twice but not /sbin or /usr/sbin. Is that how it should be? I would think that since you're including ${prefix}/sbin and /usr/local/sbin you would want the other sbin directories too. Actually, are you sure you want to include /usr/local directories there? Software installed using MacPorts should really not be using anything that might be in /usr/local.
• Do the turdfiles cause problems for qmail or why are you removing them? If they do not cause a problem you should not remove them. If they do cause a problem, then you should explain this in the comment in the post-activate phase, and you should also re-examine the second line of the post-activate phase (which tries to remove ${destroot}${prefix}/var/log/qmail/smtpd/.turd_${name}) because it has no effect: at the activate phase, there is no ${destroot} anymore.

If you could attach portfile patches to address these issues that would be great.

[compconsultant@…]

Ok, don't forget as I do not see how to do this... to rename all the patch files I originally attached per your changes to .diff, and, all the other files to .in. Also, the Macports guide does not mention port lint! I had not seen that, so, I fugured it out, but, it should be in the guide. The naming convention with .diff and .in are also mentioned nowhere, should be in the guide. You can remove append-Makefile as it is not needed based on the new Portfile I will upload.

[compconsultant@…]

I changed the way the Makefile patch was done, the new way makes more sense and fits more with Macports. Also, a bug was discovered in Leopard with vfork, so, added a few new patches to work around it. Works fine now. I asked the qmail gurus, they suggested not leaving the turd files. Let me know if it is finally good! I have more ports to contribute related to qmail, so, this was a good exercise in learning.

[compconsultant@…]

Addresses case 13313

[raimue@…]

Closing as requested in #18220, see also #18219.

[anonymous]

Milestone Port Submissions deleted