Projects
New Ticket     Wiki     Browse Source     Timeline     Roadmap     Bug Reports     Search

Ticket #14482 (closed enhancement: fixed)

Opened 9 months ago

Last modified 6 days ago

RFE: Global variant descriptions (per source)

Reported by: raimue@… Owned by: raimue@…
Priority: Normal Milestone: MacPorts 1.7.0
Component: base Version: 1.7.0
Keywords: variants descriptions Cc:
Port:

Description

There are variants which are used on multiple ports. To provide a consistent experience, these should get only one place for their description.

Proposal:

  • Add a file ${sourcepath}/.config/variant_descriptions to each source
  • The file should be formatted in Tcl style as follows:
    name1 {The description of name1 variant}
    name2 {Insert description here}
    
  • If no description was given in the Portfile itself, port variants will read this file (if present) and display the variant description from there
  • port lint should be tweaked to check for existance of global variant descriptions before spitting out warnings

Attachments

upgrade_sources_conf_default.tcl (1.9 KB) - added by blb@… 3 weeks ago.
sources.conf upgrade script

Change History

Changed 9 months ago by raimue@…

  • type changed from defect to enhancement

Changed 9 months ago by raimue@…

  • component changed from ports to base

Changed 9 months ago by raimue@…

Started a branch for this, branches/variant-descs-14482

Changed 9 months ago by raimue@…

The current style of the file in the branch is:

name1 The description of name1 variant
name2 Insert description here

Do we support multi-line descriptions for variants? Should we?

Changed 7 weeks ago by raimue@…

  • milestone changed from MacPorts base enhancements to MacPorts 1.7.0

Changed 4 weeks ago by blb@…

I've moved the install dir (containing the mtree files) into the .../share/macports directory (r41463), stopped the resources directory from being installed with base (r41462), and added [default] to sources.conf (r41458).

I think all that is left is to actually move resources to dports/.resources (and add in port1.0), then to come up with some method for handling an upgrade-style installation, since I don't think sources.conf is overwritten if it already installs.

Changed 3 weeks ago by blb@…

How does the attached script look for updating sources.conf in postflight and in the install target of the Makefile?

Changed 3 weeks ago by blb@…

sources.conf upgrade script

Changed 6 days ago by blb@…

FYI, upgrade_sources_conf_default.tcl added in r42575.

Changed 6 days ago by blb@…

I added the svnmerge-integrated property to trunk/base in r42654 so I could check to see how much is affected by the eventual merge-back. It looks like only one conflict in portlint.tcl and it's an easy one to handle; so the merge shouldn't be too much work when we're ready to do that (which should be done with the move of resources to dports/).

Changed 6 days ago by raimue@…

As of r42659 the branch is using _resources as directory name.

Changed 6 days ago by raimue@…

  • status changed from new to closed
  • resolution set to fixed

The branch variant-descs-14482 was merged to trunk in r42662 and a file for global variant descriptions was added in r42668. Marking as fixed.

Note: See TracTickets for help on using tickets.