Ticket #14635 (reopened enhancement)
php5-mysql +mysql5: simplify --with-mysql option if possible
| Reported by: | info@… | Owned by: | ryandesign@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.6.0 |
| Keywords: | Cc: | ||
| Port: | php5-mysql |
Description
There appears to be a typo in the mysql5 variant section at line 231, where "--with-mysql=${workpath}/mysql5" should be "--with-mysql=${prefix}/mysql5" ... a diff is attached. Note, if this is in fact a typo, it appears in the various other flavors of the php5 port (i.e., php5-devel, etc.) as well.
Attachments
Change History
comment:1 Changed 5 years ago by ryandesign@…
- Cc ryandesign@… removed
- Owner changed from macports-tickets@… to ryandesign@…
Is not a typo. Why do you think it should be changed?
comment:2 Changed 5 years ago by ryandesign@…
- Status changed from new to closed
- Resolution set to wontfix
No feedback, closing. If you still feel this is an issue, please reopen and explain.
comment:3 Changed 5 years ago by info@…
- Status changed from closed to reopened
- Resolution wontfix deleted
Hi, sorry for the delay. Though it may or may not have functional consequence, it does raise a flag when looking at your phpinfo()—finding a configure option that, at least on first glance, would have linked to no resource. Assuming that this configure setting has no negative effect, it ends up being misleading as a clue when troubleshooting other problems. The reason I bring this up is that when troubleshooting a problem I was having with my cms (based on php/mysql), this caught my eye, and I ended up spending time looking into it when, in the end, it was not an issue.
There may be a very good reason for the approach you took, but if there's an equally effective alternative (that doesn't cause the confusion mentioned above), I'd humbly suggest using the alternative. For my own purposes, I changed the port as I'd proposed with this patch and all builds and functions without issue.
Thanks for your consideration!
comment:4 Changed 5 years ago by ryandesign@…
The option was written that way in the portfile when I inherited it. I did not know that your way would also work. Since your way is clearly simpler, I assumed that would have been used before if it had worked. When I have some time I will attempt to research why the portfile is written the way it's written, and see if we can change it without adverse consequences.
Note that there is also talk of changing the layout of the mysql5 portfile's contents to be "less weird". This may affect this option in the php portfiles (and all other portfiles that use mysql) as well.
comment:5 Changed 5 years ago by ryandesign@…
- Summary changed from Patch for php5 portfile to php5: simplify --with-mysql option if possible
- Type changed from defect to enhancement
- Milestone changed from Port Bugs to Port Enhancements
The portfile works as it is, so this is an enhancement request, not a bug report.
comment:7 Changed 4 years ago by anonymous
- Milestone Port Enhancements deleted
Milestone Port Enhancements deleted
comment:8 Changed 4 years ago by ryandesign@…
- Keywords php5 removed
- Port set to php5-mysql
- Summary changed from php5: simplify --with-mysql option if possible to php5-mysql +mysql5: simplify --with-mysql option if possible
FYI: The code in question was moved to the php5-mysql port's +mysql5 variant.