#15135 closed defect (fixed)
variant +sidebar of port mutt-devel fails patch phase
| Reported by: | shreevatsa.public@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.6.0 |
| Keywords: | mutt, mutt-devel, patch | Cc: | |
| Port: |
Description
Trying to port install mutt-devel +sidebar, it fails. (Actually I had a long list of variants that I was trying to apply to mutt-devel; it's possible one of the others was conflicting with this.) I guess the patch is out-of-date with the version of mutt-devel that MacPorts is using. It probably just requires fixing the offset etc. and can be done manually.
Change History (6)
comment:1 Changed 16 years ago by shreevatsa.public@…
comment:2 Changed 16 years ago by raimue (Rainer Müller)
If two patches conflict, they can't get applied automatically. Conflicts always require manual resolution.
comment:3 Changed 16 years ago by shreevatsa.public@…
Well, I thought there must exist some tools that keep track of patches a bit more smartly, and decrease the need for manual resolution. I vaguely remember seeing that quilt can do something in this direction (I think it lets one specify the order in which patches should be applied).
[Offtopic: I don't really know what would be a good way to solve this, since variants introduce a combinatorial explosion that makes it hard to test all cases. mutt-devel has 21 variants, which means there are more than *two million* ways of installing it. This is terrible, especially for a port that has no maintainers. Many of those variants could simply be turned on... I think variants of the form "--enable-feature" should be generally encouraged to not be variants at all, when they do not cause any undesirable consequences.]
comment:4 Changed 16 years ago by shreevatsa.public@…
For any future users encountering this problem: the two conflicting variants are +nntp and +sidebar.
comment:5 Changed 16 years ago by jmroot (Joshua Root)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I marked those variants as conflicting in r36310, which is all we can really do. Quilt is a very handy tool, but it's for keeping track of patch series, where each patch applies to the result of the last. It doesn't resolve the conflicts for you, it just makes it easy to update the patches after they are resolved.
Yeah, mutt-devel +sidebar works fine by itself. I guess one of the others was conflicting. Fixing this probably requires changing the way the patch phase works -- is it possible to do it so that there are no conflicts? Would tools like quilt help?
[Can I change the component of this ticket to MacPorts Base bugs?]