rsync-3.0.3 should fully preserve Mac OS X metadata

[css@…]

The rsync port does not include a couple essential patches that preserve Mac OS X metadata. See  Mike Bombich's instructions to find that there are two patches.

• fileflags.diff preserves Finder flags.
• crtimes.diff preserves file creation dates.

The port should provide a variant to support these patches. Adding them as a regular variant rather than a platform-specific variant should allow supporting these attributes when using the port on non-darwin systems. Ideally, the port could:

• Fetch the official patches archive:  http://rsync.samba.org/ftp/rsync/rsync-patches-3.0.2.tar.gz
• Apply the two patches
• Fully support Mac OS X metadata backups!

Unfortunately, I'm not entirely clear on the best way to do this in terms of the Portfile. The quick and dirty approach is to grab those patches and directly put them into the port's folder. It might be nice to directly use the official archive in the event that future patches are deemed useful.

[css@…]

Here's an identifiable desired outcome for this patch: The MacPorts rsync port passes the  Backup Bouncer test.

[css@…]

updated patch for rsync 3.0.3 patches

[css@…]

Reassigning to the new maintainer...

[simon@…]

I committed this in r38182, but added the patches as default; the variant "no_macosx_metadata" disables them.

If you don't like this, please tell me and I will change it.

Thanks for your patch,

Simon

[css@…]

To follow up on the performance, here are the test results for rsync 3.0.5:

/opt/local/bin/rsync -aH -E --crtimes --fileflags --xattrs --acls

------------------ rsync-macports ------------------
Verifying:    basic-permissions ... ok (Critical)
Verifying:           timestamps ... ok (Critical)
Verifying:             symlinks ... ok (Critical)
Verifying:    symlink-ownership ... ok 
Verifying:            hardlinks ... ok (Important)
Verifying:       resource-forks ... ok (Critical)
Verifying:         finder-flags ... ok (Critical)
Verifying:         finder-locks ... ok 
Verifying:        creation-date ... ok 
Verifying:            bsd-flags ... ok 
Verifying:       extended-attrs ... ok (Important)
Verifying: access-control-lists ... ok (Important)
Verifying:                 fifo ... ok 
Verifying:              devices ... ok 
Verifying:          combo-tests ... ok 

Seems like a rock-solid mirroring tool for Mac OS X!

[anonymous]

Milestone Port Enhancements deleted