Projects
New Ticket     Wiki     Browse Source     Timeline     Roadmap     Bug Reports     Search

Ticket #15472 (closed defect: fixed)

Opened 6 months ago

Last modified 5 months ago

rsync-3.0.3 should fully preserve Mac OS X metadata

Reported by: css@… Owned by: simon@…
Priority: Normal Milestone: Port Enhancements
Component: ports Version: 1.6.0
Keywords: Cc:
Port:

Description

The rsync port does not include a couple essential patches that preserve Mac OS X metadata. See Mike Bombich's instructions to find that there are two patches.

  • fileflags.diff preserves Finder flags.
  • crtimes.diff preserves file creation dates.

The port should provide a variant to support these patches. Adding them as a regular variant rather than a platform-specific variant should allow supporting these attributes when using the port on non-darwin systems. Ideally, the port could:

Unfortunately, I'm not entirely clear on the best way to do this in terms of the Portfile. The quick and dirty approach is to grab those patches and directly put them into the port's folder. It might be nice to directly use the official archive in the event that future patches are deemed useful.

Attachments

patch-Portfile.diff (1.5 KB) - added by css@… 5 months ago.
updated patch for rsync 3.0.3 patches

Change History

Changed 6 months ago by css@…

Here's an identifiable desired outcome for this patch: The MacPorts rsync port passes the Backup Bouncer test.

Changed 5 months ago by css@…

updated patch for rsync 3.0.3 patches

Changed 5 months ago by css@…

  • summary changed from rsync-3.0.2 should fully preserve Mac OS X metadata to rsync-3.0.3 should fully preserve Mac OS X metadata

Changed 5 months ago by css@…

  • owner changed from mww@… to simon@…

Reassigning to the new maintainer...

Changed 5 months ago by simon@…

  • status changed from new to closed
  • resolution set to fixed

I committed this in r38182, but added the patches as default; the variant "no_macosx_metadata" disables them.

If you don't like this, please tell me and I will change it.

Thanks for your patch,

Simon

Note: See TracTickets for help on using tickets.