git-core update to 1.5.6.3

[maccheck@…]

version bumping git-core from 1.5.6.2 to 1.5.6.3, again ;-)

[raimue (Rainer Müller)]

maccheck, as you are continuously providing updates for git-core, I would like to add you to the list of maintainers of git-core.

Bryan, do you have any objections?

[bryan@…]

No objections, as long as you guys keep running the test suite and a sanity test before checking in! Things have been running smoothly for the last while, so I'm content with how you're running things.

[raimue (Rainer Müller)]

The test suite is kind of useless for git-core in MacPorts, because it always fails when using root privileges.

*** t0004-unwritable.sh ***
*   ok 1: setup
* FAIL 2: write-tree should notice unwritable repository


                (
                        chmod a-w .git/objects
                        test_must_fail git write-tree
                )
                status=$?
                chmod 775 .git/objects
                (exit $status)

root always has permission to write, even when chmod a-w is done before. This will become better when the GSoC project for dropping privileges is completed. But until then, I don't see an easy way to run the test suite and rely on it.

Workaround:

cd $(port work git-core)/git-$(port -q info --version git-core)
sudo chown -R $USER .
make test

[maccheck@…]

I saw on the Git mailing list that there is already a patch for this test, so that it will be skipped if run with root privileges. I don't know if this will get accepted or not, nevertheless.

​http://kerneltrap.org/mailarchive/git/2008/6/30/2296944

[raimue (Rainer Müller)]

Committed in r38355.

Added maccheck to the list of maintainers in r38356.

[(none)]

Milestone Port Updates deleted