Ticket #15975 (closed update: fixed)
git-core update to 1.5.6.3
| Reported by: | maccheck@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.6.0 |
| Keywords: | git-core Portfile patch | Cc: | bryan@…, raimue@… |
| Port: |
Description
version bumping git-core from 1.5.6.2 to 1.5.6.3, again ;-)
Attachments
Change History
comment:1 Changed 5 years ago by raimue@…
maccheck, as you are continuously providing updates for git-core, I would like to add you to the list of maintainers of git-core.
Bryan, do you have any objections?
comment:2 Changed 5 years ago by bryan@…
No objections, as long as you guys keep running the test suite and a sanity test before checking in! Things have been running smoothly for the last while, so I'm content with how you're running things.
comment:4 follow-up: ↓ 5 Changed 5 years ago by raimue@…
The test suite is kind of useless for git-core in MacPorts, because it always fails when using root privileges.
*** t0004-unwritable.sh ***
* ok 1: setup
* FAIL 2: write-tree should notice unwritable repository
(
chmod a-w .git/objects
test_must_fail git write-tree
)
status=$?
chmod 775 .git/objects
(exit $status)
root always has permission to write, even when chmod a-w is done before. This will become better when the GSoC project for dropping privileges is completed. But until then, I don't see an easy way to run the test suite and rely on it.
Workaround:
cd $(port work git-core)/git-$(port -q info --version git-core) sudo chown -R $USER . make test
comment:5 in reply to: ↑ 4 Changed 5 years ago by maccheck@…
I saw on the Git mailing list that there is already a patch for this test, so that it will be skipped if run with root privileges. I don't know if this will get accepted or not, nevertheless.