Opened 20 years ago

Closed 19 years ago

Last modified 18 years ago

#1598 closed defect (fixed)

add $Id$ to base/, add -V (version info) to port, please comment

Reported by: opendarwin.org@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: base Version: 1.0
Keywords: Cc: jberry@…
Port:

Description

I went through base/ and added $Id$ to everything but man pages and mtree/. I also added a -V flag to port, "port -V" returns "Version 0.1000 ($Id$)". If you see anything that should be changed, discussed, beaten into the ground, etc. please let me know. For the .c/.h files I've added the $Id$ as a #define, for .tcl files I've made it a variable (more on this below), elsewhere its just commented. Note that the patch is a diff of base/, so its all jumbled together. I can break it out in different ways if that's easier to digest. I chose to use variables in the .tcl files in hopes that in the future (if desired) we can have "port -V" (or whatever) dump all of the $Id$ tags for the darwinports infrastructure in use. Not that grep can't do this, but for those less familiar w/ CLI tools "port -V" may be easier, and it may be easier to wrap up in a GUI. I synched my base/ at 2004/03/07 20:57 (US/Pacific) and patched directly onto that. Testing was to do:


configure/make/make install port -V port installed port clean port +ssl install (from the net/wget directory)


Attachments (1)

dports_base_20040307.22.24.diff (43.7 KB) - added by opendarwin.org@… 20 years ago.
big fat patch to base/ to add $Id$

Download all attachments as: .zip

Change History (7)

Changed 20 years ago by opendarwin.org@…

big fat patch to base/ to add $Id$

comment:1 Changed 19 years ago by blb@…

With 'port version' and 'port selfupdate' these days, can this bug be closed?

comment:2 Changed 19 years ago by opendarwin.org@…

Resolution: later
Status: newclosed

Yeah, we can close this. I'm marking the resolution as LATER 'cause I still think its a good idea to tag all the files in base/.

comment:3 Changed 19 years ago by pguyot (Paul Guyot)

Resolution: later
Status: closedreopened

comment:4 Changed 19 years ago by pguyot (Paul Guyot)

Resolution: fixed
Status: reopenedclosed

comment:5 Changed 18 years ago by jmpp@…

Cc: jberry@… added

Hey Erick, James! Regardless of having version information in dp now, I like the idea of tagging files in base with Id info. I believe Paul already did a lot of this, so I'm unsure if your patch applies any longer. May you please check Erick, and update the patch as required? James, what you reckon about this move?

-jmpp

comment:6 Changed 18 years ago by jberry@…

I'm not opposed to $Id$ on files in HEAD, but I'm not dogmatic about it either. There's a lot of disagreement within the cvs/svn community about whether $Id$ is good or not. It becomes a problem with branches. But I generally add $Id$ when I make a new file...

Note: See TracTickets for help on using tickets.