New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #16007 (closed enhancement: fixed)

Opened 4 years ago

Last modified 3 years ago

Allow cairo to build 64-bit

Reported by: jmr@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: pguyot@…, arcata@…, mcalhoun@…
Port: cairo, cairo-devel

Description

Attached patch uses the value of the universal_archs variable if present instead of hardcoding {i386 ppc}, and disables Quartz font support if building for 64-bit, since that feature uses Carbon functions that are not present in the 64-bit libs.

Attachments

patch-quartz-lp64.diff Download (0.9 KB) - added by jmr@… 3 years ago.
patch from #17040

Change History

  Changed 4 years ago by ryandesign@…

Are you able to build cairo universal? What about #15451?

  Changed 4 years ago by jmr@…

Building cairo universal works in trunk with universal_archs set to {i386 x86_64}. I didn't try with universal_archs set to {i386 ppc}, nor with 1.6.0 where that would always be the case.

  Changed 4 years ago by ryandesign@…

  • status changed from new to assigned

Now using ${universal_archs} as of r38946.

  Changed 3 years ago by jmr@…

  • cc pguyot@… added
  • port set to cairo

Has duplicate #17040 which refers to upstream bug  http://bugs.freedesktop.org/show_bug.cgi?id=15702.

  Changed 3 years ago by pguyot@…

Sorry for the dup #17040. Interestingly, the patches and the approaches differ. Patch in #17040 does not disable quartz font building, just atsui support, which is AFAIK the only thing that doesn't work on 64 bits.

  Changed 3 years ago by jmr@…

The new patch does look a lot better. I think it should always be applied though, not just in the universal variant. Some systems will build 64-bit by default.

  Changed 3 years ago by ryandesign@…

  • cc arcata@… added
  • port changed from cairo to cairo, cairo-devel

Has duplicate #17176.

Changed 3 years ago by jmr@…

patch from #17040

  Changed 3 years ago by jmr@…

Ryan, are you going to commit this, or shall I time out and commit it myself? ;-)

  Changed 3 years ago by ryandesign@…

That's just Glen's patch from the upstream cairo ticket, yes? I'll try it out shortly, then ping the cairo developers about getting it properly included in the source.

  Changed 3 years ago by jmr@…

Yes, it's the upstream patch.

  Changed 3 years ago by ryandesign@…

Works for me on Leopard on Intel so I committed it to the cairo port in r45305. Thanks everyone.

  Changed 3 years ago by ryandesign@…

Committed to the cairo-devel port in r45971.

  Changed 3 years ago by mcalhoun@…

  • cc mcalhoun@… added

Cc Me!

  Changed 3 years ago by anonymous

  • milestone Port Enhancements deleted

Milestone Port Enhancements deleted

follow-up: ↓ 16   Changed 3 years ago by mcalhoun@…

Can this ticket now be closed?

in reply to: ↑ 15   Changed 3 years ago by mcalhoun@…

  • status changed from assigned to closed
  • resolution set to fixed

Replying to mcalhoun@…:

Can this ticket now be closed?

Closing since there were no objections.

Note: See TracTickets for help on using tickets.