build.nice broke the ability to redefine build.cmd as a series of commands

[ryandesign (Ryan Carsten Schmidt)]

ocaml can't be built when "buildnicevalue" is greater than zero in macports.conf. This happens:

--->  Building ocaml
DEBUG: Executing org.macports.build (ocaml)
DEBUG: Environment: MACOSX_DEPLOYMENT_TARGET='10.4'
DEBUG: Assembled command: 'cd "/mp/var/macports/build/_Users_rschmidt_macports_dports_lang_ocaml/work/ocaml-3.10.2" && nice -n 1 unset LD_PREBIND LD_PREBIND_ALLOW_OVERLAP && make world.opt'
nice: unset: No such file or directory
Error: Target org.macports.build returned: shell command " cd "/mp/var/macports/build/_Users_rschmidt_macports_dports_lang_ocaml/work/ocaml-3.10.2" && nice -n 1 unset LD_PREBIND LD_PREBIND_ALLOW_OVERLAP && make world.opt " returned error 127
Command output: nice: unset: No such file or directory

Warning: the following items did not execute (for ocaml): org.macports.activate org.macports.build org.macports.destroot org.macports.install
Error: Status 1 encountered during processing.
$

[pguyot (Paul Guyot)]

I'd rather say it's build.nice feature that broke the possibility to redefine build.cmd as a series of commands :)

build.cmd "cmd1 && cmd2" -> cmd1 will be niced, not cmd2

build.cmd "shell stuff cmd" -> shell stuff will break (where shell stuff can be a built-in such as unset as here, or VAR=X)

[afb@…]

Fixed, r38577.

Now skipping nice for all build commands with a space.

[ryandesign (Ryan Carsten Schmidt)]

Replying to afb@…:

Fixed, r38577.

Now skipping nice for all build commands with a space.

That's not really a fix, it's more of a workaround. I filed #18304 for enabling nice builds even in this case.