Opened 16 years ago

Closed 10 years ago

#16201 closed defect (fixed)

Upgrading openssh overwrites user-modified config files

Reported by: vinc17@… Owned by: neverpanic (Clemens Lang)
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc: nonstop.server@…
Port: openssh

Description

The openssh port shouldn't overwrite user-modified config files (ssh_config and sshd_config), or should introduce some mechanism to do config file upgrades safely. For instance, contents between some markers could be preserved, e.g.

# BEGIN local configuration
...
# END local configuration

In such a case, such configuration should be near the beginning of the file. The ssh_config man page says:

     For each parameter, the first obtained value will be used.  The configu-
     ration files contain sections separated by ``Host'' specifications, and
     that section is only applied for hosts that match one of the patterns
     given in the specification.  The matched host name is the one given on
     the command line.

     Since the first obtained value for each parameter is used, more host-spe-
     cific declarations should be given near the beginning of the file, and
     general defaults at the end.

I don't know about sshd_config. I suppose that the same rule is applied.

Change History (8)

comment:1 Changed 16 years ago by wsiegrist@…

Owner: changed from wms@… to macports-tickets@…

Un-assigning due to dropping maintainership.

comment:2 Changed 15 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

comment:3 Changed 14 years ago by vinc17@…

Owner: changed from macports-tickets@… to jwa@…
Port: openssh added

I think it should be assigned to the new maintainer...

The bug is still present in openssh @5.5p1 for both the config files in /etc/ssh and org.macports.OpenSSH.plist (which disables sshd).

comment:4 Changed 13 years ago by jon+mp@…

This bug recently bit me too, and my /opt/local/etc/ssh_config changed were wiped.

comment:5 Changed 12 years ago by ttelford.groups@…

This bug keeps biting me - every single time the OpenSSH configuration is updated.

comment:6 Changed 12 years ago by nonstop.server@…

Cc: nonstop.server@… added

Cc Me!

comment:7 Changed 10 years ago by neverpanic (Clemens Lang)

Owner: changed from jwa@… to cal@…
Status: newassigned

The openssh port in its current version preserves existing copies of $prefix/etc/ssh/ssh{,d}_config. I'm not sure why it should preserve modifications to the launchd plist, though.

I consider this fixed, please re-open if you think different (pun intended!).

comment:8 Changed 10 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.