e2fsprogs: common symbols not allowed with MH_DYLIB output format with the -multi_module option

[joshua.friedman@…]

I'm on os x 10.4 and e2fsprogs is failing to link.

making all in lib/ext2fs
        GEN_BSD_SOLIB libext2fs.2.1.dylib
ld: common symbols not allowed with MH_DYLIB output format with the -multi_module option
tdb.o definition of common _tdb_null (size 8)
/usr/bin/libtool: internal link edit command failed
make[2]: *** [libext2fs.2.1.dylib] Error 1
make[1]: *** [all-libs-recursive] Error 1
make: *** [all] Error 2

[macsforever2000@…]

Assigning to maintainer.

[bdenckla@…]

Here's some observations I can add that are possibly useful: (a) I can reproduce this problem, (b) it goes away if I remove --enable-bsd-shlibs, and (c) it does not exist on 10.5.

[anonymous]

Milestone Port Bugs deleted

[niel.drummond@…]

modified patch in /opt/local/var/macports/sources/rsync.macports.org/release/ports/sysutils/e2fsprogs/files/patch-lib__Makefile.darwin-lib which passes compile ( reference  http://www.mail-archive.com/gcc@gcc.gnu.org/msg05799.html ).

[niel.drummond@…]

Cc Me!

[blb@…]

Cc reporter of dup #20548.

[ryandesign@…]

The problem is Tiger-specific and remains with 1.41.8 to which I just updated the port.

#20548 suggests the solution:

Add

CFLAGS = -O2 -fno-common

in file: lib/ext2fs/Makefile

I have not tested this.

[ryandesign@…]

Replying to niel.drummond@…:

modified patch in /opt/local/var/macports/sources/rsync.macports.org/release/ports/sysutils/e2fsprogs/files/patch-lib__Makefile.darwin-lib which passes compile ( reference  http://www.mail-archive.com/gcc@gcc.gnu.org/msg05799.html ).

I committed your update in r55267, which I agree does seem to allow the build on Tiger, and does not seem to affect the build on Leopard.