Opened 16 years ago

Closed 15 years ago

#16432 closed defect (fixed)

diffstat uses distname without version in it

Reported by: carl.shapiro@… Owned by: tim@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: diffstat Cc: ryandesign (Ryan Carsten Schmidt)
Port:

Description

The diffstat port routinely fails to build when a new version of diffstat has been released and MacPorts has not caught up. This problem is affecting the diffstat port as the most current version of diffstat is 1.46 and the port references 1.45. The reason for this is that the Portfile specifies a distfile name that is a soft link for the latest version. The distfile should use the specific distribution file name, not the soft link to the most recent version. A patch is provided below.

Attachments (2)

diffstat.diff (572 bytes) - added by carl.shapiro@… 16 years ago.
diffstat-ryandesign.diff (634 bytes) - added by ryandesign (Ryan Carsten Schmidt) 16 years ago.

Download all attachments as: .zip

Change History (6)

Changed 16 years ago by carl.shapiro@…

Attachment: diffstat.diff added

comment:1 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added
Owner: changed from macports-tickets@… to tim@…

Carl, please remember to assign tickets to the port owner so that they may see and act upon them.

I can confirm that this problem exists, but I propose a different fix, which I attach.

Tim: please indicate whether I may commit this fix to your port.

Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: diffstat-ryandesign.diff added

comment:2 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Summary: diffstat uses unstable distfile namediffstat uses distname without version in it

See also #16413 for the requested update to version 1.46.

comment:3 Changed 15 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

comment:4 Changed 15 years ago by tobypeterson

Resolution: fixed
Status: newclosed

I apparently fixed this in r49304

Note: See TracTickets for help on using tickets.