base/src/port/port.tcl should quote homepage when opening it

[blb@…]

In the code for handling the gohome command, the $homepage variable is not quoted when passed to the shell, which causes issues when a character handled by the shell is present in the homepage. To see this, try port gohome xdvipdfmx and note that the page loaded has everything from the & to the end stripped. To see a more catastrophic error, try port gohome libksba (at least until that port's homepage is corrected).

[raimue@…]

Shouldn't that be single quotes? With double quotes, there is still replacement for $HOME or other environment variables happening. Unlikely that it appears in an homepage URL, but let's fix it completely.

[blb@…]

diff to base/src/port/port.tcl (on trunk)

[blb@…]

Hmm, yeah, not sure why I went with double, even with singles not having to be escaped. Patch updated.

[raimue@…]

Committed your patch in r40414.

[toby@…]

Milestone MacPorts base bugs deleted