New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #16554 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Gnucash 2.2.5_1 does not build due to typos in gnc-module.c and gnc-exp-parser.c

Reported by: pgijnxn02@… Owned by: macsforever2000@…
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: build, typo Cc: jmr@…
Port: gnucash

Description

An extra < at the top of the files prevents gnucash from building.

error: <guile16/gh.h: No such file or directory

Removing the extra < resulted in success. Unfortunately I didn't think to capture a diff for you.

Attachments

gnucash-Portfile.diff Download (0.8 KB) - added by illogical1@… 3 years ago.
diff against gnucash portfile with proposed fix
Portfile Download (4.6 KB) - added by illogical1@… 3 years ago.
Actual portfile so user can test if Portfile works

Change History

  Changed 3 years ago by jmr@…

  • cc jmr@… added

I can't reproduce this. If there's a problem, it would be in the reinplace on line 66 of the Portfile. You don't have any local modifications? Can you tweak the reinplace expression to get it to work?

follow-up: ↓ 3   Changed 3 years ago by pgijnxn02@…

My Portfile line 66: reinplace "s|\\<guile\\/|\<guile16\\/|g" ${src_file}

I see that there are two \\ before <guile and only one \ before <guile16. Would that do it?

I don't have local modifications. What other information would be useful?

in reply to: ↑ 2   Changed 3 years ago by pgijnxn02@…

This remains true in 2.2.7_1. gnc-module.c and gnc-exp-parser.c won't build until I modify the <guile16/gh.h line in each. After that, they're fine.

Changed 3 years ago by illogical1@…

diff against gnucash portfile with proposed fix

Changed 3 years ago by illogical1@…

Actual portfile so user can test if Portfile works

  Changed 3 years ago by pgijnxn02@…

Great, thanks!

Unfortunately I can't test this at the moment because it's not building for other reasons: the dependency gnome-desktop  needs xrandr 1.2, which I don't seem to have, so it doesn't build.

...unless you know of a way to update my version of xrandr? I have Tiger 10.4.11 on PPC. But we're getting a bit off-topic now, aren't we? :)

  Changed 3 years ago by macsforever2000@…

  • status changed from new to assigned
  • owner changed from macports-tickets@… to macsforever2000@…

  Changed 3 years ago by macsforever2000@…

  • status changed from assigned to closed
  • resolution set to fixed

Committed revision r40485. Strangely it always worked for me without the patch, but adding this patch does not hurt anything for me. Thanks!

  Changed 3 years ago by pgijnxn02@…

Works for me now :)

  Changed 3 years ago by anonymous

  • milestone Port Bugs deleted

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.