New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #17062 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

gimp2: +quartz variant

Reported by: pguyot@… Owned by: devans@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc:
Port: gimp2

Description

gimp2 almost compiles with gtk2+quartz and friends. It just needs a small tweak, and the attached patch just does this (plus adds some logic inspired from the gtk2/pango logic to mark it as +quartz or +x11 depending on what version of gtk2 is installed and activated).

Attachments

gimp2_quartz.diff Download (1.4 KB) - added by pguyot@… 3 years ago.
patch-gimp2-Portfile-quartz.diff Download (1.9 KB) - added by devans@… 3 years ago.
Modified patch for Portfile

Change History

Changed 3 years ago by pguyot@…

Changed 3 years ago by devans@…

  • owner changed from db.evans@… to devans@…
  • status changed from new to assigned

Thanks for this, I'll give it a try. I still haven't been able to get gtk2 +no_x11 to compile on Tiger which is all I have available to me so I assume you are using Leopard? By the way, I'm trying to stay will +no_x11 instead of +quartz as that is the way most of the other ports are going.

Changed 3 years ago by jmr@…

That exec grep is going to throw an error when it doesn't find GDK_WINDOWING_QUARTZ, so you'll need to catch it. The same applies to gnome-desktop, BTW.

Changed 3 years ago by pguyot@…

@devans: yes, this is on 10.5 (just upgraded a few days ago). @jmr: oops. Thanks for spotting this. I fixed the logic for gnome-desktop in r41405 (and for eel in r41406). The same fix should be applied to this patch.

Changed 3 years ago by devans@…

Here is the modified patch to allow building gimp2 +quartz +no_x11. Tested now in both with and without +quartz +no_x11 on Tiger using patch from #16978 (not yet committed) to allow building of gtk +no_x11 on Tiger. If you'll confirm this works on Leopard will commit it. Thanks for your help.

Changed 3 years ago by devans@…

Modified patch for Portfile

Changed 3 years ago by devans@…

  • status changed from assigned to closed
  • resolution set to fixed

Committed modified patch in r41518. Thanks.

Changed 3 years ago by pguyot@…

The +quartz variant works as expected on 10.5.5/x86.

Changed 3 years ago by anonymous

  • milestone Port Bugs deleted

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.