New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #17128 (closed enhancement: fixed)

Opened 5 years ago

Last modified 4 years ago

RFE: change faad2 depends_lib to depends_build

Reported by: mcalhoun@… Owned by: pguyot@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc:
Port: faad2

Description

I believe that faad2 only depends on libtool, autoconf, and automake
during the build stage.

I don't think it depends on perl at all.

Attached is the proposed change.

Attachments

Portfile.diff (417 bytes) - added by mcalhoun@… 5 years ago.

Change History

comment:1 Changed 5 years ago by pguyot@…

Have you tried with -t to back your assumption?

I probably cannot get more spam, and I'd rather have my e-mail the same on all ports so I can easily grep.

Changed 5 years ago by mcalhoun@…

comment:2 Changed 5 years ago by mcalhoun@…

Trying to install in trace mode results in an error:

aclocal: aclocal: file `/opt/local/share/aclocal/wxwin.m4' does not exist

The offending perl code in aclocal is:

fatal "$where: file `$file' does not exist" if ! -e $file;

There is probably no easy fix to this.

I could find no evidence that libtool, autoconf, or automake were needed after building.
Are they ever?
I could find no mention of perl anywhere.

These dependencies where initially introduced in r19951.

I modified the patch file to keep the old address.

comment:3 Changed 5 years ago by mcalhoun@…

May I go ahead and commit this patch?

comment:4 Changed 5 years ago by mcalhoun@…

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r42217.

comment:5 Changed 4 years ago by anonymous

  • Milestone Port Enhancements deleted

Milestone Port Enhancements deleted

Note: See TracTickets for help on using tickets.