New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #17349 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

svn.tag should be called svn.rev

Reported by: ryandesign@… Owned by: macports-tickets@…
Priority: Normal Milestone: MacPorts 1.8.0
Component: base Version: 1.6.0
Keywords: svn.tag svn.revision deprecate Cc: raimue@…
Port:

Description

The svn.tag keyword should really be called svn.rev because it is where you put the revision of the repository you would like to check out. I'm sure it's just called "tag" since it was probably copied from (or maybe even shares code with) the cvs checkout feature, where cvs.tag makes sense, since it's the tag name you want to check out.

We should allow svn.rev as a synonym of svn.tag. Then, once we release a version of MacPorts with that change, we should mass-update all ports to use svn.rev instead. Then we can modify port lint to issue a warning if you use svn.tag and suggest you use svn.rev instead.

Change History

Changed 3 years ago by ryandesign@…

  • cc raimue@… added

Changed 3 years ago by raimue@…

  • keywords svn.tag svn.revision deprecate added
  • milestone changed from MacPorts Future to MacPorts 1.8.0

Oh, I have not been aware of this ticket before doing r48223.

I made it a ui_warn message now. I will take a look if we can also make it count as a warning in lint by adding another option_proc there.

Changed 3 years ago by raimue@…

Now the warning is only printed on lint, see r51565, r51569, r51570, r51572, r51574.

Changed 3 years ago by jmr@…

  • status changed from new to closed
  • resolution set to fixed

Looks fixed to me.

Note: See TracTickets for help on using tickets.