coin needs updated X11 dependencies

[jeremyhu@…]

Index: Portfile
===================================================================
--- Portfile	(revision 42954)
+++ Portfile	(working copy)
@@ -17,9 +17,13 @@
 checksums		md5 1e7cb6afa69f6eed034a64021f7d1bfc \
 			sha1 19dc61398d843bff120aec9c640ea814c827b577
 
-depends_build		lib:libX11.6:XFree86 bin:doxygen:doxygen
-depends_lib		port:simage
+depends_build bin:doxygen:doxygen
 
+depends_lib \
+	port:simage \
+	lib:libSM.6:xorg-libsm \
+	lib:libXext.6:xorg-libXext
+
 use_configure		yes
 configure.args		--with-simage=${prefix} --mandir=${prefix}/share/man
 
@@ -30,7 +34,8 @@
 variant aqua requires darwin {
 	configure.args-delete	--without-framework --enable-darwin-x11
 	configure.args-append	--with-framework=${destroot}/Library/Frameworks  --without-x
-	depends_build-delete	lib:libX11.6:XFree86
+	depends_build-delete	lib:libSM.6:xorg-libsm
+	depends_build-delete	lib:Xext.6:xorg-libXext
 }
 
 variant devel {

[css@…]

Bugs need to provide more than just the patch ... what failed? Which OS version and hardware are you using? If there are related tickets describing the updated dependencies, please link to them.

[css@…]

(or I could wade through that big unread X11 mail thread... !) :)

[css@…]

I'm still unclear ... why the change in dependencies?

[jeremyhu@…]

1) Your X11 dependency is just a buildtime dependency, but you actually need it at runtime as well. 2) You are not depending on libSM, but you need libSM 3) You are not depending on libXext, but you need libXext

Also, I think you should probably change the doxygen dependency to port:doxygen.

[jeremyhu@…]

See, libX11 is not enough:

$ otool -L /opt/local/lib/libCoin.dylib 
/opt/local/lib/libCoin.dylib:
	/opt/local/lib/libCoin.40.dylib (compatibility version 46.0.0, current version 46.0.0)
	/usr/X11/lib/libGL.1.dylib (compatibility version 1.2.0, current version 1.2.0)
	/usr/X11/lib/libXext.6.dylib (compatibility version 11.0.0, current version 11.0.0)
	/usr/X11/lib/libXdmcp.6.dylib (compatibility version 7.0.0, current version 7.0.0)
	/usr/X11/lib/libXau.6.dylib (compatibility version 7.0.0, current version 7.0.0)
	/usr/X11/lib/libSM.6.dylib (compatibility version 7.0.0, current version 7.0.0)
	/usr/X11/lib/libICE.6.dylib (compatibility version 10.0.0, current version 10.0.0)
	/usr/X11/lib/libX11.6.dylib (compatibility version 9.0.0, current version 9.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 111.0.0)
	/usr/lib/libstdc++.6.dylib (compatibility version 7.0.0, current version 7.4.0)
	/usr/lib/libgcc_s.1.dylib (compatibility version 1.0.0, current version 1.0.0)

libSM depends on libICE

libXext depends on libX11 which depends on libXau and libXdmcp

So you need libSM and libXext.

[css@…]

Ah, so that helps to make sure everything is thoroughly covered. Thanks for the proactivity and providing the details!

I have a build running at the moment...

[css@…]

I might be able to remove doxygen as a default dependency, because it's really only used when building the documentation.

[css@…]

Updated dependencies and added variant descriptions

[jeremyhu@…]

That looks good to me. Push it =)

[css@…]

Committed to r43863!

[anonymous]

Milestone Port Bugs deleted