New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #17615 (closed enhancement: duplicate)

Opened 4 years ago

Last modified 3 years ago

Only convert receipts if it's actually needed

Reported by: jmr@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: base Version: 1.8.0
Keywords: Cc:
Port:

Description

In Mk/macports.upgrade.mk, we currently run sed on every receipt to replace db/dports with macports, and create a .mpsaved backup regardless of whether anything was replaced. It would be nice if we only did this when it's needed.

Change History

comment:1 Changed 4 years ago by blb@…

Should we just test for ${prefix}/var/macports/.mprename or use something else?

comment:2 in reply to: ↑ description Changed 4 years ago by jmpp@…

Replying to jmr@…:

In Mk/macports.upgrade.mk, we currently run sed on every receipt to replace db/dports with macports, and create a .mpsaved backup regardless of whether anything was replaced. It would be nice if we only did this when it's needed.

This would certainly be an enhancement to my upgrade code. I guess you've seen that, when reinstalling even freshly new MacPorts sources, the upgrade code taps into the receipts of newly installed ports, which of course have no need of being upgraded from the dp namespace. This should not happen, period, so performing an extra check to determine the necessity of the upgrade is definitely advisable. Maybe grep'ping first for dp/dports per receipt and examining the exit value...?

However, please notice my recent ticket #17619 in the 1.8.0 milestone, in which I request considering the removal of the dp2mp upgrade code altogether, now that we are well into the lifespan of the MacPorts namespace.

-jmpp

comment:3 Changed 4 years ago by jmr@…

  • Status changed from new to closed
  • Resolution set to duplicate

Let's just nuke the upgrade code as per #17619.

comment:4 Changed 3 years ago by jmr@…

  • Milestone MacPorts Future deleted
Note: See TracTickets for help on using tickets.