Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#17634 closed defect (fixed)

rdesktop update for X11 detection

Reported by: jeremyhu (Jeremy Huddleston Sequoia) Owned by: cshbell@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: x11 universal parallel Cc: noses@…
Port: rdesktop

Description

rdesktop uses '--x-include' and '--x-lib', but it should autoreconf instead to get a autoconf-2.63 built configure which does a better job of finding X11.

This also isn't using libtool, so it's not building universal

And it builds in parallel fine...

Index: Portfile
===================================================================
--- Portfile	(revision 43655)
+++ Portfile	(working copy)
@@ -23,15 +23,22 @@
 homepage	http://rdesktop.sourceforge.net/
 master_sites	sourceforge
 
-depends_lib	lib:libX11.6:XFree86 \
+universal_variant no
+use_parallel_build yes
+
+depends_build	port:autoconf
+
+depends_lib	lib:libX11.6:xorg-libX11 \
 		port:openssl \
 		port:libiconv \
 		port:libao
 
+use_autoconf	yes
+autoconf.cmd	autoreconf
+autoconf.args	-fvi
+
 configure.args		--mandir=${prefix}/share/man \
-			--x-includes=${x11prefix}/include \
-			--x-libraries=${x11prefix}/lib \
-			--with-libao=${prefix} \
+			--with-sound=libao \
 			--with-openssl=${prefix} \
 			--with-libiconv-prefix=${prefix}
 

Change History (4)

comment:1 Changed 15 years ago by jeremyhu (Jeremy Huddleston Sequoia)

oh yeah... it doesn't use --with-libao any more either.

comment:2 Changed 15 years ago by cshbell@…

Sounds good. Go ahead and commit the change.

comment:3 Changed 15 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: fixed
Status: newclosed

done, thanks.

comment:4 Changed 15 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.